Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
schaubh
force-pushed
the
feature/bsk_1629_orbitalMotion
branch
from
October 19, 2026 15:18
8be8804 to
950c37b
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improve numerical accuracy and robustness across the orbitalMotion libraries and related modules while preserving existing APIs, NumPy scalar outputs, and legacy conventions without deprecations. Add optional checked APIs and enforce inclinations between 0 and 180 degrees.
The six commits cover Kepler solvers, orbital conversions and KeplerianOrbit, mean-element and Hill transformations, environmental helpers and bindings, eclipse calculations, and documentation.
Verification
Added numerical, compatibility, and downstream regression tests. Updated partial-eclipse references using independent high-precision calculations and removed AVS test selectors that performed no checks.
Validation was performed locally on macOS. The external-renderer OpNav Monte Carlo example was reviewed but not executed.
Documentation
Updated API documentation, affected module documentation, the AVS library manual, known issues, and release notes. Added an orbital-motion compatibility guide documenting preserved conventions, validation behavior, and supported domains.
Future work
Further near-parabolic improvements using universal-variable formulations remain outside this PR.