Skip to content

Improve orbitalMotion robustness and preserve API compatibility - #1630

Open
schaubh wants to merge 6 commits into
developfrom
feature/bsk_1629_orbitalMotion
Open

schaubh wants to merge 6 commits into
developfrom
feature/bsk_1629_orbitalMotion

Conversation

@schaubh

@schaubh schaubh commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

Description

Improve numerical accuracy and robustness across the orbitalMotion libraries and related modules while preserving existing APIs, NumPy scalar outputs, and legacy conventions without deprecations. Add optional checked APIs and enforce inclinations between 0 and 180 degrees.

The six commits cover Kepler solvers, orbital conversions and KeplerianOrbit, mean-element and Hill transformations, environmental helpers and bindings, eclipse calculations, and documentation.

Verification

  • 12,182 CI-selected Python tests passed, with no skips.
  • 544 native and 97 Rust tests passed.
  • Build, standalone-header checks, and focused Sphinx/Doxygen validation passed.
  • Additional randomized C/Python reconstruction checks passed.

Added numerical, compatibility, and downstream regression tests. Updated partial-eclipse references using independent high-precision calculations and removed AVS test selectors that performed no checks.

Validation was performed locally on macOS. The external-renderer OpNav Monte Carlo example was reviewed but not executed.

Documentation

Updated API documentation, affected module documentation, the AVS library manual, known issues, and release notes. Added an orbital-motion compatibility guide documenting preserved conventions, validation behavior, and supported domains.

Future work

Further near-parabolic improvements using universal-variable formulations remain outside this PR.

@schaubh
schaubh requested a review from a team as a code owner October 19, 2026 00:21
@schaubh schaubh self-assigned this Oct 19, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-19T00:27:06.417311Z 8be8804 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@schaubh
schaubh force-pushed the feature/bsk_1629_orbitalMotion branch from 8be8804 to 950c37b Compare October 19, 2026 15:18

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

Improve numerical robustness, API consistency, and validation of the orbitalMotion libraries

1 participant