Repository navigation
Selfo: show the selected piece and the cells it can reach - #504
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #503 (which was merged before its last commit, so that one is included here).
marked with dots. With the
no-enclosurevariant only the cells allowed bythat rule are marked.
move()now accepts{partial: true}. A half-entered move (just the piece)plays nothing and only sets the marks;
validateMovesetscanrenderforthat case and for the empty move, so the front end previews it.
gameinfo.urlslinks the Wikipedia article on Selfo (the commit missingfrom Selfo: no colour starts one move away from winning #503).
Tests: new "half-entered moves" block (marks match the legal moves with and
without
no-enclosure, nothing is played, marks clear once a move is made,complete moves flagged as partial still play, invalid selections still throw).
npm run buildpasses and the Selfo tests pass; checked by hand in the localplayground.