Fix ImHex pattern tile_size_in_fh truncation and extend tile/AUI/gainmap parsing - #285
Merged
Merged
Conversation
…sing to ImHex pattern Signed-off-by: KP Choi <19379257+kpchoi@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
util/apv.hexpat.Bug fixes:
tile_size_in_fh : 32 * NumTilesis truncated to 8 bits by the patternengine whenever 32 * NumTiles >= 256, desynchronizing the whole pattern for
streams with
tile_size_present_in_fh_flag = 1and NumTiles >= 8. It is nowan array of 32-bit bitfield members.
use_companding(444-16C12 / 4444-16C12, see readme/apv_ext.md) instead of showing
reserved_zero_8bits = 128, with a warning when set for other profiles.sync, and payload structs consume any unread remainder.
malformed pbu_size and tile sizes; invalid tile_info skips the frame data
with a warning instead of forcing a parse.
New parsing:
tile_size,tile_header()fields (tile_index,tile_data_size[], tile_qp[]) and a sealed tile data blob.
frame_info().
frame PBU (pbu_type 28) from the APV gainmap/ICC specification draft.
Console output:
configurations, metadata payload types).
position, keyed by (pbu_type, group_id) so coexisting frames such as
previews are not reported as changes.
verbose = trueat the topof the pattern.