Skip to content

ImHex pattern: simplify quantization_matrix() and show bit-exact frame_header size - #286

Merged
cpncf merged 2 commits into
mainfrom
bitfield_size_display_wrap
Sep 23, 2026
Merged

cpncf merged 2 commits into
mainfrom
bitfield_size_display_wrap

Conversation

@kpchoi

@kpchoi kpchoi commented Sep 23, 2026

Copy link
Copy Markdown
Collaborator

Updates util/apv.hexpat.

  • The 256 hardcoded quantization matrix fields (qmatrix0_00 .. qmatrix3_63)
    are replaced by a QMatrixComp q_matrix[NumComps] bitfield array with one
    named field per coefficient, grouped by color component.
  • FrmHeader is wrapped in an inlined empty bitfield so that ImHex treats it
    as a bitfield member and shows a bit-exact size (e.g. "19 bytes, 3 bits")
    instead of rounding up to whole bytes.
  • The frame_header placement is named "frame_header()" again; it was
    mislabeled "frame_info()".

Signed-off-by: KP Choi <19379257+kpchoi@users.noreply.github.com>
…ttern

Signed-off-by: KP Choi <19379257+kpchoi@users.noreply.github.com>

@cpncf cpncf left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hot Fix. LGTM

@cpncf
cpncf merged commit 553b3c9 into main Sep 23, 2026
10 checks passed
@cpncf
cpncf deleted the bitfield_size_display_wrap branch September 23, 2026 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants