Conversation
Clamp left_shift = oapv_clip3(0, 30, -shift) in oapv_dquant() as defense-in-depth against out-of-range shift exponents. Signed-off-by: Fyodor Kyslov <kyslov@google.com>
kpchoi
requested changes
Sep 28, 2026
| } | ||
| else { | ||
| int left_shift = -shift; | ||
| int left_shift = oapv_clip3(0, 30, -shift); |
Collaborator
There was a problem hiding this comment.
The clamp is not needed. left_shift is already bounded by the bitstream validation:
dq_shiftis derived asbit_depth - 2 - qp / 6.bit_depthis checked to be in[10, 16], andtile_qpin[0, MAX_QUANT(bit_depth)], whereMAX_QUANT(bit_depth) = 63 + (bit_depth - 10) * 6.- So
qp / 6is at mostbit_depth, anddq_shiftis always in[-2, bit_depth - 2].
In this branch left_shift is therefore always in [0, 2], and oapv_clip3(0, 30, -shift) can never change it. It would only add an operation to the dequantization path, so this change cannot be accepted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds defense-in-depth shift clamping in
oapv_dquant()(src/oapv_tq.c):left_shift = oapv_clip3(0, 30, -shift)before left-shiftingcoef[i] * q_matrix[i]inoapv_dquant().Testing
ctestunit/conformance tests pass with AddressSanitizer and UndefinedBehaviorSanitizer.