fix(web): track Brave browser URLs - #307
Open
NikitaMGrimm wants to merge 3 commits into
Open
NikitaMGrimm wants to merge 3 commits into
NikitaMGrimm wants to merge 3 commits into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #306.
Brave's page events omit the toolbar from
event.source, so read itsurl_barfrom the active window. Ignore the bar while it is focused, when it can show Brave's search hint.I checked
example.com→ IANA on an Android 16 emulator: both URLs appear in the web bucket. Chrome still records the same navigation. Watcher unit tests pass, and the Android test sources compile.Before / after (the after clip includes repeated test visits):
aw-android-brave-before-after-continuous.mp4