Skip to content

docs(dirs): note that XDG_* is ignored on macOS/Windows and must stay that way - #160

Merged
ErikBjare merged 1 commit into
masterfrom
docs/platformdirs-xdg-comment
Sep 25, 2026
Merged

ErikBjare merged 1 commit into
masterfrom
docs/platformdirs-xdg-comment

Conversation

@ErikBjare

Copy link
Copy Markdown
Member

Comment-only. platformdirs (and the dirs crate in aw-server-rust) ignore XDG_* on macOS/Windows, and all components must resolve identical paths. Documents this so nobody special-cases XDG_* in one component (see ActivityWatch/aw-client#119).

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@ErikBjare
ErikBjare merged commit 33c8528 into master Sep 25, 2026
5 checks passed
@greptile-apps

greptile-apps Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

[Low risk] Adds a comment to the directory resolution code.

The PR appears safe to merge.

Summary

This comment-only PR documents platformdirs’ platform-specific XDG behavior and advises against component-specific XDG path handling.

  • It also points tests toward patching platformdirs, consistent with the existing directory tests.

Reviews (1) · Last reviewed commit: "docs(dirs): note that XDG_* is ignored o..."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant