Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #943 +/- ##
==========================================
+ Coverage 63.30% 64.09% +0.79%
==========================================
Files 52 52
Lines 3608 3643 +35
Branches 840 840
==========================================
+ Hits 2284 2335 +51
+ Misses 1309 1308 -1
+ Partials 15 0 -15 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
8d5b91d to
348d949
Compare
|
@0xbrayo ready or no? |
|
@ErikBjare not yet tested. |
|
Compiles and works, as far as I can test, Ready for merge :) |
348d949 to
9b12c04
Compare
Migrate the last src/ .js modules and JS Vue SFCs to TypeScript, point webpack/Vite at src/main.ts, and add unit tests for tooltip, swimlane, and filters. Test files and tooling configs stay JavaScript.
- Rename all remaining `.js` tests (unit and e2e) to `.ts` and point jest at `*.test.ts`. - `queries.test.node.js` clashed with the existing `queries.test.node.ts`, so the snapshot test becomes `queriesSnapshot.test.node.ts` with its snapshot. - Convert `vite.config.js` to `vite.config.ts` (already referenced by `tsconfig.node.json`). - Add `tsconfig.test.json` and `npm run typecheck:test`; ts-jest runs with `isolatedModules`, so jest alone doesn't type-check the tests. Fix the type errors this surfaced.
93e15d6 to
f9864c9
Compare
The last application JavaScript under
src/is now TypeScript. Test files and root tooling configs are unchanged.What changed
src/modules to.ts:main,route,stores/index,mixins/asyncErrorCaptured,util/{fakedata,filters,swimlane,tooltip}.<script lang="ts">onCustomVisualization.vue,Calendar.vue, andSunburstClock.vue.vue.config.js) and Vite atsrc/main.ts, and dropped explicit.jsimport suffixes.anyonly where needed so Vue 2 Options API plus lodash/moment still typecheck. No Options API → composition rewrite, andstrictis still off.Tests
New jsdom tests (still
.js, as requested) cover the shippedbuildTooltip,getSwimlane, and Vue filter registrations. Existingroute.test.jsstill imports the router.Jest: 35 suites, 229 tests. Production build succeeds.