Skip to content

Update ember-raf-scheduler - #1252

Merged
eliasdawson-addepar merged 3 commits into
masterfrom
rm-register-waiter
Sep 16, 2026
Merged

eliasdawson-addepar merged 3 commits into
masterfrom
rm-register-waiter

Conversation

@eliasdawson-addepar

@eliasdawson-addepar eliasdawson-addepar commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor

Update dependency ember-raf-scheduler and remove usage of registerWaiter method. registerWaiter is deprecated and a no-op as of ember-raf-scheduler@0.5.0. https://github.com/html-next/ember-raf-scheduler/blob/master/src/register-waiter.js.

Updating ember-raf-scheduler required additional changes. @html-next/vertical-collection@v4 depends on ember-raf-scheduler@0.3.0. The version conflict resulted in tests in the embroiderSafe scenario using 0.3.0 and thus not waiting properly. This PR updates @html-next/vertical-collection to v5 to prevent this conflict.

Updating @html-next/vertical-collection to v5 also required additional changes to the template and build config.

@stepsecurity-app

stepsecurity-app Bot commented Sep 14, 2026 •

Copy link
Copy Markdown

✅ Resolved — a later workflow run passed this policy check.

Original alert (resolved)

Security Policy Alert: Actions Policy Violation

This workflow run has been blocked by StepSecurity's actions policy.

Actions Not Pinned to SHA:

  • jdx/mise-action@v4

To fix this issue, please pin each action to a full 40-character commit SHA instead of a tag or branch reference.

For more information, see StepSecurity's Actions Policy documentation.

@eliasdawson-addepar
eliasdawson-addepar marked this pull request as draft September 14, 2026 21:12
@eliasdawson-addepar
eliasdawson-addepar force-pushed the rm-register-waiter branch 2 times, most recently from 9e00d83 to cd5ea18 Compare September 15, 2026 20:14
Update dependency ember-raf-scheduler. Remove
deprecated, no-op call to registerWaiter
Update dependency @html-next/vertical-collection
to dedupe dependency ember-raf-scheduler
Comment thread .github/workflows/ci.yml

@eliasdawson-addepar eliasdawson-addepar Sep 16, 2026 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to these changes, but StepSecurity failed the build because these were unpinned. @arshabh-agarwal not this is also blocking all Dependabot and other automated PRs. If we don't land this PR for some reason, we should pull this out to unblock.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check this carefully. I'm not very familiar with this format, and the {{#vertical-collection...}}...{{else} construction in particular.

@eliasdawson-addepar
eliasdawson-addepar marked this pull request as ready for review September 16, 2026 18:39

@mixonic mixonic left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow very cool!

@eliasdawson-addepar
eliasdawson-addepar merged commit e88206e into master Sep 16, 2026
16 of 18 checks passed
@eliasdawson-addepar
eliasdawson-addepar deleted the rm-register-waiter branch September 16, 2026 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants