Skip to content

feat: Gray out disabled chapters, show DISABLED tooltip - #1632

Merged
EttyKitty merged 4 commits into
mainfrom
automation/dispatch-1791494652
Oct 8, 2026
Merged

EttyKitty merged 4 commits into
mainfrom
automation/dispatch-1791494652

Conversation

@EttyKitty

@EttyKitty EttyKitty commented Oct 8, 2026 •

Copy link
Copy Markdown
Collaborator

Disabled chapters draw icons at 0.5 alpha and replace hover description with DISABLED.


Summary by cubic

Disabled chapters now render at 50% opacity and show a "DISABLED" tooltip on hover instead of their usual description, so locked chapters are immediately identifiable in the creation menu.

Written for commit 4cdeabc. Summary will update on new commits.

View guided diff

Disabled chapters draw icons at 0.5 alpha and replace hover description with DISABLED.
@github-actions github-actions Bot added Size: Tiny Type: Feature Adds something new labels Oct 8, 2026
@EttyKitty EttyKitty changed the title feat(creation): gray out disabled chapters and show DISABLED tooltip feat: Gray out disabled chapters, show DISABLED tooltip Oct 8, 2026
@EttyKitty

Copy link
Copy Markdown
Collaborator Author

/oc Address these points (implement, unless they introduce regressions and I'm wrong): 1. Unless I'm wrong, I think slate4 is never mutated from the scope of draw_chapter_select function. As such, I think slate4 / 30 always produces the same value, yet the op is now repeated 14 times in the file. I don't think that's needed, and the result can likely be cached in a local var at the earliest point, then reused. 2. chap.disabled ? 0.5 : 1 is now copy-pasted 4 times. Again, can likely be cached to a local var at the earliest point and reused.

Cache slate4 / 30 in _base_alpha once per draw, and chap.disabled factor in _disabled_alpha per chapter, removing repeated expressions.
@lyra-cactus

lyra-cactus Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

Changes pushed to branch automation/dispatch-1791494652.

@EttyKitty
EttyKitty marked this pull request as ready for review October 8, 2026 21:55
@EttyKitty

Copy link
Copy Markdown
Collaborator Author

/review

lyra-cactus[bot]
lyra-cactus Bot previously approved these changes Oct 8, 2026

@lyra-cactus lyra-cactus Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - small, focused change. Alpha caching (_base_alpha) and static DISABLED_ALPHA clean up repeated slate4 / 30 math, icon dimming is correctly scoped with restore after each draw, and click guards already prevent selecting disabled chapters. One i18n nit below.

Comment thread scripts/scr_creation_draw_slides/scr_creation_draw_slides.gml Outdated
@EttyKitty
EttyKitty merged commit 4f6a5e2 into main Oct 8, 2026
4 checks passed
@EttyKitty
EttyKitty deleted the automation/dispatch-1791494652 branch October 8, 2026 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Size: Tiny Type: Feature Adds something new

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant