Repository navigation
fix: Promote issues - #1634
Merged
Merged
fix: Promote issues#1634
Conversation
Collaborator
Author
|
/review |
Contributor
There was a problem hiding this comment.
LGTM. Verified all 6 files: multi-company reorder in scr_promote correctly captures source companies before move_to_company and includes target; scr_company_order guard matches valid 0..companies range; promote gating on managing > 0 plus sel_promoting resets (Alarm_6 else, group_selection) correctly close the adhoc/stale-state crash; player_role_data reorder before marine load is a pure move with no logic change and preserves overrides. No bugs, regressions, or style violations found. ASCII clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1633
Summary by cubic
Fixes several issues with the promote action and save loading that caused crashes and incorrect role data.
player_role_datais now applied before marine structs load, so role overrides survive deserialization correctly. Closes [main/2026-10-08-1819] scr_company_order:143 #1633.Written for commit e180d8d. Summary will update on new commits.