Conversation
gunicsba
added this pull request to stack #86
September 19, 2026 22:08
gunicsba
force-pushed
the
feature/track-control-levels
branch
from
September 19, 2026 22:58
cbde51f to
ce392c5
Compare
…tate (DDI 515) Negotiates a track control level with implements and switches their track control on and off together with AgOpenGPS's Auto command: 1. The implement reports the levels it supports as a bitmask in DDI 505. 2. The TC writes DDI 506 (an enum, unlike 505) back. Only Level 1 is implemented, so it asks for Level 1 whenever the implement supports it, even if it also advertises Level 2 or 3. 3. The implement's DDI 506 echo completes the negotiation. DDI 515 (TrackControlState) is written only to clients that completed the negotiation, each time AOG's section control mode arrives. The guidance data from the previous PR is not gated on any of this. The DDIs are mapped with find_owning_element_number() from the guidance data mapping, plus an OnChange subscription because the implement reports them. Also announces functionality 27 (Task Controller TRACK server) in PGN 64654 and shows the track state and the implement's supported levels on the VT status page. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
gunicsba
force-pushed
the
feature/track-control-levels
branch
from
September 19, 2026 23:04
ce392c5 to
679b293
Compare
…levels Resolve conflict in request_measurement_commands(): keep the track control DDI subscriptions and switch their output to log() to match the async logging from #79. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…levels Picks up the test_guidance_track link fix. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Last of four PRs split out of #73. Stacked on #84 (base is
feature/guidance-track-announcement; GitHub retargets it as the PRs below it merge).Negotiates a track control level with the implement and switches its track control on and off together with AgOpenGPS's Auto command:
0= none,1= Level 1, ...). Only Level 1 is implemented, so it asks for Level 1 whenever the implement supports it, even if it also advertises Level 2 or 3.1) completes the negotiation.DDI 515 (
TrackControlState) is written only to clients that completed the negotiation, each time AOG's section-control mode (PGN0xF1) arrives. Everything from #83/#84 is deliberately not gated on this.Also: announces functionality 27 (Task Controller TRACK server) in PGN 64654, and shows the track state and the implement's supported levels on the VT status page.
Differences from the tramline branch
This is a port, not a copy. I dropped things that were dead or redundant there:
activate_object_pool—ClientStateis freshly constructed on every activation, so the negotiation state already starts zeroed, and the flags it set were never read (or duplicatedhas_element_number_for_ddi).actualTramlineControlStateandtrackControlEnabledflags — written, never read.ActualTramlineCondensedWorkState*handling. Nothing uses it while only Level 1 exists, and it is where the DDI-range bug from the Implement TECU capabilities announcement and tramline support for specific seeders #73 review lived. It can come back with Level 3.TrackControlLevel,send_guidance_track_data, ...).Left out on purpose, worth a follow-up: the diagnostic repetition-rate callback that #73 registered on the TC's PGN-request protocol (depends on #82's helper), and #73's fallback that derives an implement's working width from live-reported values (an unrelated feature).
Things to check on hardware
TaskControllerServer).0xF1arrives. If AOG sends that only on change and an implement finishes negotiating afterwards, it won't get the current state until the next toggle. Same behaviour as Implement TECU capabilities announcement and tramline support for specific seeders #73; I didn't change it.Track state,Track levels) in the same text object.Test plan
AOG_TC_VALIDATE_IOP=ONbuild,ctest6/6; clang-format clean locally.🤖 Generated with Claude Code