TPC: Add sector edge fluctuation correction infrastructure#15532
Open
matthias-kleiner wants to merge 5 commits into
Open
TPC: Add sector edge fluctuation correction infrastructure#15532matthias-kleiner wants to merge 5 commits into
matthias-kleiner wants to merge 5 commits into
Conversation
Add option to correct for sector edge fluctuations. The time intervals and sectors with optional scaling factors are parsed from CSV table. Two new CCDB types are added: 1. CalSecEdgeCorrection: the correction map with per sector delta fluctuations 2. CalSecEdgeInfo: the time intervals with optional per sector scaling factors for which the CalSecEdgeCorrection will be applied The applied scaling factors are added to the TPC timeseries for visualisation.
wiechula
requested changes
Jun 23, 2026
| tpcopt.lumiMode = static_cast<LumiScaleMode>(lumiModeVal); | ||
|
|
||
| tpcopt.enableMShapeCorrection = opts.get<bool>("enable-M-shape-correction"); | ||
| tpcopt.enableSecEdgeFlucCorrection = opts.get<bool>("enable-sec-edge-fluc-correction"); |
Collaborator
There was a problem hiding this comment.
Perhaps the default should be on, so one could rename this to disable-...
Contributor
Author
|
Thanks @wiechula for the comments. I just fixed them |
matthias-kleiner
requested review from
chiarazampolli,
davidrohr,
sgorbuno and
shahor02
as code owners
shahor02
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SectorEdgeFluctuationsclass parses a CSV table of run/time intervals and optional per-sector scaling factors stored in CCDB asCalSecEdgeInfoCalSecEdgeCorrectionholds per-sector delta distortion maps, applied based on the sectors and scaling factors from SectorEdgeFluctuationsTPCFastSpaceChargeCorrectionHelperextended to support per-sector scaling factorsTPCScalerSpecand enabled via--enable-sec-edge-fluc-correctionTimeSeriesITSTPCfor visualisation in the TPC time series