Flow working - #1
Open
ilanmitnikov wants to merge 3 commits into
Open
ilanmitnikov wants to merge 3 commits into
ilanmitnikov wants to merge 3 commits into
Conversation
mariogeiger
reviewed
Jun 29, 2024
| x0, x1 = align_with_rotation(x0, x1) | ||
|
|
||
| gamma = lambda t: jnp.sqrt(t * (1 - t)) | ||
| gamma_dot = lambda t: (1 / (2 * jnp.sqrt(t * (1 - t) + 1e-2))) * ( |
Collaborator
There was a problem hiding this comment.
You could write jax.grad(gamma) here for clarity
Comment on lines
8
to
23
| tensorclouds.egg-info/dependency_links.txt | ||
| tensorclouds.egg-info/requires.txt | ||
| tensorclouds.egg-info/top_level.txt | ||
| tensorclouds/data/__init__.py | ||
| tensorclouds/data/protein.py | ||
| tensorclouds/gen/__init__.py | ||
| tensorclouds/gen/diffusion.py | ||
| tensorclouds/gen/flow_matching.py | ||
| tensorclouds/gen/mirror_interpolant.py | ||
| tensorclouds/gen/two_sided_interpolant.py | ||
| tensorclouds/gen/utils.py | ||
| tensorclouds/loss/__init__.py | ||
| tensorclouds/loss/losses.py | ||
| tensorclouds/nn/__init__.py | ||
| tensorclouds/nn/autoencoder.py | ||
| tensorclouds/nn/decoder.py |
Collaborator
There was a problem hiding this comment.
You really want to commit this file?
| next_zt = next_zt.replace( | ||
| irreps_array=e3nn.IrrepsArray( | ||
| next_zt.irreps_array.irreps, | ||
| next_zt.irreps_array.array * (zt.irreps_array.array != 0.0), |
Collaborator
There was a problem hiding this comment.
Can you explain me this?
Owner
There was a problem hiding this comment.
The reason for this is that the irreps_arrays are also masked irreps-wise. That is, out of 14x1e, some might not exist, and we don't want to accumulate that when forwarding the transport.
However, we are migrating towards the tensorcloud object having a x.irreps_array_mask attribute, with shape [leading_shape, num_irreps], so that we can simply x.irreps_array_mask * x.irreps_array
Collaborator
There was a problem hiding this comment.
It would look much cleaner 👌
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.