Repository navigation
Respect htmx 4's HX-Request-Type: full header - #948
Open
scriptogre wants to merge 2 commits into
Open
scriptogre wants to merge 2 commits into
scriptogre wants to merge 2 commits into
Conversation
HX-Request-Type: full header
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
htmx 4 sends
HX-Request-Type: fullwhenhx-targetis<body>, or whenhx-selectis used.Otherwise, it sends
HX-Request-Type: partial.hx-boostmakes an htmx request with an implicithx-target="body", and thus it sendsHX-Request-Type: full.FastHTML sees
HX-Requestand treats this as a fragment request. It renders<head>children directly alongside body content:Instead of placing them inside
<head>in a complete<html>document:Fix
Render the full
<html>whenHX-Request-Type: fullheader is present.Also add
HX-Request-TypetoVaryso caches separate full-page and fragment responses.