[TM ONLY] Makes phones works across Z-levels and other areas - #156
[TM ONLY] Makes phones works across Z-levels and other areas#156DiscordWizard wants to merge 3 commits into
Conversation
| sim_card = new default_sim_card_type(src) | ||
| sim_card.phone_weakref = WEAKREF(src) | ||
| phone_radio = new(src) | ||
| phone_radio = new /obj/item/radio/phone(src) |
There was a problem hiding this comment.
| phone_radio = new /obj/item/radio/phone(src) | |
| phone_radio = new(src) |
unneeded, phone_radio is an implicit type defined by the var, meaning New() doesn't need to be passed a type
| /obj/item/radio/phone/can_receive(input_frequency, list/levels) | ||
| return ..(input_frequency, RADIO_NO_Z_LEVEL_RESTRICTION) // without this, phones only work on their own Z level | ||
|
|
There was a problem hiding this comment.
(NON-BLOCKING) i was going to ask you to modular comment this, but this is a PR that should go upstream after the testing cycle so i'll just mark this as TM only instead for now. me or @FalloutFalcon will upstream it for you if you don't end up getting around to it.
dwinters99
changed the title
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~7 days. Please address any outstanding review items and ensure your PR is finished - if both are true, and you have auto-staled anyway, you need to actively ask maintainers (by pinging them in the Apocrypha XIII Discord) to (re)review or merge your PR. If no maintainer responds to your request, you may wish to close this PR yourself while you seek maintainer comment, as you will later be able to reopen the PR yourself. |
2 participants
About The Pull Request
Makes phones work so if you are in the city and get called from residential or the top of the tower or wherever, you still get the call.
Why It's Good For The Game
Bugfix, and now we can all communicate properly, welcome back anxiety-less communication.
Tested calling on the same Z-level, different areas, atop one another and next to one another, calling works fine.
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑
fix: phone calling work across z-levels
/:cl: