Repository navigation
chore(config): remove the unused allow block - #71
Merged
Merged
Conversation
Contributor
|
Hi @Vondry Regards |
The commented-out `allow:` block promised to limit who can see the shortlink, canonical, robots and og:type fields, but nothing has ever read it. It was copied with the rest of the config from the original Bolt 3 extension (bobdenotter/seo), where `SeoExtension::seoAllowedConfig()` checked it against Bolt 3 user roles. That function wasn't ported, and no release of this package has had code for it. Sites that uncommented it showed every field to every editor anyway.
Vondry
force-pushed
the
chore/remove-unused-allow-config
branch
from
October 24, 2026 19:58
c6823c7 to
4dfac0b
Compare
Contributor
Author
|
The failing JS tests job isn't caused by this PR. #74 fixes that test and is green. This PR only removes commented lines from Once #74 is merged, I'll rebase this branch onto |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the commented-out
allow:block fromconfig/config.yaml:Nothing reads it, so it suggests a feature the extension doesn't have. There are no code changes.
Where it came from
bolt/bolt: ^3.0) has the same block inconfig/config.yml.dist. There,SeoExtension::seoAllowedConfig()checked it against the current user's Bolt 3 roles, and_seo_extension_field.twigused the result to hide those four fields.config/config.yaml(8f50343, 2020-11-18), butseoAllowedConfig()was never ported. Its role names (chief-editor,admin,developer,root) are Bolt 3 roles, not Bolt 4+ roles such asROLE_CHIEF_EDITOR.1.0.0–1.0.12,2.0.0–2.2.0) and no commit onmainhas had code that readsallow. Sites that uncommented it saw no effect: every editor still sees all fields.Impact
None. Existing sites keep their own copy of
appolo-boltseo.yaml, because Bolt never updates it. The block in that copy stays harmless, and new installs no longer get it.Verified
git grepoversrc/,templates/,assets/and every release tag finds no code that readsallow.config/config.yamlstill parses, andvendor/bin/phpunitpasses (143 tests, after rebasing ontomain).Related
Rebased onto
mainafter #68, which rewrote thetemplates:comment right below this block. The conflict was only that the two changes sit next to each other.#74 fixes
npm testonmain(the shortlink JS test left over from #72). It doesn't touchconfig/config.yaml, so the two PRs merge in either order.