Skip to content

Fix objectives-run-out check and restore most-points winner backfill - #5959

Merged
wholton merged 1 commit into
masterfrom
fix-objectives-run-out
Oct 22, 2026
Merged

wholton merged 1 commit into
masterfrom
fix-objectives-run-out

Conversation

@wholton

@wholton wholton commented Oct 22, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Restores run_against_all_games as the most-points winner backfill for ended games that ran out of objectives without a winner, so it can be dry-run again. This replaces the Ignis Aurora unit-upgrade cleanup that master currently has in that command (still in git history).
  • Fixes EndGameService.objectivesHaveRunOut. It only looked at the peekable (set-aside) list, which is empty in games that never set it up, and used a round > 7 cutoff. That made nearly every ended game count as out of objectives (the first dry run listed about 700 games, many at round 1 with 0 VP), and offered the End Game button from round 8 in live games.
  • All ten public objectives are flipped by the end of round 8 status, so the first status phase with nothing left is round 9. The check is now: past round 9, or round 9 once the game has reached the status or agenda phase, or both the set-aside row and the main deck are empty. Omega Phase keeps its round > 9 rule.

Test plan

  • RunAgainstAllGamesTest (new cases for round 9 status/agenda/action, round 10, round 8 status, unpeeked deck)
  • Re-run /developer run_against_all_games as a dry run and check the list shrinks to games that reached round 9 status

🤖 Generated with Claude Code

run_against_all_games records the most-points winner in ended games
that ran out of objectives, ready for another dry run.

objectivesHaveRunOut only looked at the peekable (set-aside) list, which
is empty in games that never set it up, and used a round > 7 cutoff.
All ten public objectives are flipped by the end of round 8's status
phase, so the first status phase with nothing left is round 9's.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

🔬 Test Results

✅ JSON Validation

No JSON files changed.


✅ Formatting Checks Passed

All files pass Spotless formatting.


✅ JUnit Tests Passed

All tests passed successfully.

@wholton
wholton merged commit 8f469fd into master Oct 22, 2026
3 checks passed
@wholton
wholton deleted the fix-objectives-run-out branch October 22, 2026 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant