Repository navigation
Fix objectives-run-out check and restore most-points winner backfill - #5959
Merged
Merged
Conversation
run_against_all_games records the most-points winner in ended games that ran out of objectives, ready for another dry run. objectivesHaveRunOut only looked at the peekable (set-aside) list, which is empty in games that never set it up, and used a round > 7 cutoff. All ten public objectives are flipped by the end of round 8's status phase, so the first status phase with nothing left is round 9's. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
🔬 Test Results✅ JSON ValidationNo JSON files changed. ✅ Formatting Checks PassedAll files pass Spotless formatting. ✅ JUnit Tests PassedAll tests passed successfully. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
run_against_all_gamesas the most-points winner backfill for ended games that ran out of objectives without a winner, so it can be dry-run again. This replaces the Ignis Aurora unit-upgrade cleanup that master currently has in that command (still in git history).EndGameService.objectivesHaveRunOut. It only looked at the peekable (set-aside) list, which is empty in games that never set it up, and used around > 7cutoff. That made nearly every ended game count as out of objectives (the first dry run listed about 700 games, many at round 1 with 0 VP), and offered the End Game button from round 8 in live games.Test plan
RunAgainstAllGamesTest(new cases for round 9 status/agenda/action, round 10, round 8 status, unpeeked deck)/developer run_against_all_gamesas a dry run and check the list shrinks to games that reached round 9 status🤖 Generated with Claude Code