network: reintroduce deprecated desk modifier chat - #63
Open
cn-cn-cn wants to merge 1 commit into
Open
Conversation
the description of `chat` was removed in 3c2c2b9, probably because it was incorrect. the actual behavior varies. servers handle it as follows: - [Akashi](https://github.com/AttorneyOnline/akashi/blob/16cee9e27c7db7fa7b4dd4c1288ebfbf05e28a2c/src/packet/packet_ms.cpp#L128) rewrites it to 1 server-side - [KFO-server](https://github.com/Crystalwarrior/KFO-Server/blob/7b17981d8b88faacdb9c778679fa4a60c881c868/server/network/aoprotocol.py#L875-L876) rewrites it to 1 server-side - [Nyathena](https://github.com/SyntaxNyah/Nyathena/blob/86b15e69666f0635e7be4aee67a3f14335f85c66/internal/athena/netprotocol.go#L813-L816) rewrites it to 1 server-side (skidded from Akashi) - [serverD](https://github.com/AttorneyOnline/serverD/blob/2c037e28f2400cb4e781059c053199151d074038/server_shared.pb#L560) passes it through verbatim clients handle it as follows: - WebAO[[1]](https://github.com/AttorneyOnline/webAO/blob/76941bf99c5e7ba4deda080013ac8173e02a1c2a/webAO/packets/handlers/handleMS.ts#L61)[[2]](https://github.com/AttorneyOnline/webAO/blob/76941bf99c5e7ba4deda080013ac8173e02a1c2a/webAO/viewport/utils/handleICSpeaking.ts#L245-L249) rewrites it to 1 - [AO2](https://github.com/AttorneyOnline/AO2-Client/blob/master/src/courtroom.cpp#L4095) rewrites it to 0 - [AsyncAO](https://github.com/SyntaxNyah/AsyncAO/blob/main/internal/protocol/ms.go#L169-L171) rewrites it to 0 (skidded from AO2) for consistent behavior across different servers and clients, servers and clients should rewrite it to 1 or reject it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the description of
chatwas removed in 3c2c2b9, probably because it was incorrect. the actual behavior varies.servers handle it as follows:
clients handle it as follows:
for consistent behavior across different servers and clients, servers and clients should rewrite it to 1 or reject it.