Repository navigation
v0.22.0 — seed lists on similar/sfxSimilar; remotes honour max_score/dedupe - #22
Merged
Merged
Conversation
AudioScape:similar and AudioScape:sfxSimilar (and their AudioScapeClient
mirrors) accept a list of seeds — an array of anything the single-seed form
accepts, or `{ asset_ids = { ... }, limit = ... }` — and send it to the API
as one `asset_ids` CSV. Results sound like the set as a whole; seeds are
never returned. `result.meta.seeds_used` / `seeds_ignored` report which
seeds the API blended and which it skipped.
- resolveSeedIds runs before resolveAssetId; Track tables, Sounds and
AudioPlayers never enter the list arm, so existing calls are unchanged.
- Similar / SfxSimilar remotes accept `asset_ids` alongside `asset_id`.
- Lune specs for string / Track / options-table lists, bad element,
empty list.
AudioScapeClient.similar / sfxSimilar sent both fields, but the server-side remotes rebuilt the options table without them, so client-initiated calls never filtered near-duplicates. SimilarOptions / SfxSimilarOptions gain the two fields the legacy options-table form already accepted at runtime.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AudioScape:similarandAudioScape:sfxSimilar(and theAudioScapeClientmirrors) accept a list of seeds — an array of anything the single-seed form accepts (asset_id string, Track,Sound,AudioPlayer), or{ asset_ids = { ... }, limit = ... }. Results sound like the set as a whole: playlist continuation for music, variety packs for SFX.Up to 100 seeds; seeds are never returned. The list ships as one comma-separated
asset_idsquery parameter.Also fixed: the
Similar/SfxSimilarRemoteFunctions dropped the client'smax_scoreanddedupe, so near-duplicate filtering never applied to client-initiated calls.Details
resolveSeedIdsruns beforeresolveAssetId. Track tables, Sounds and AudioPlayers never enter the list arm, so existing single-seed calls are unchanged.SimilarInput/SfxSimilarInput,SimilarOptions.asset_ids,SimilarResult.meta.seeds_used/seeds_ignored(and the SFX twins);max_score/dedupeadded to the options-table types.wally.toml0.22.0.Checks
StyLua, selene, luau-lsp analyze,
wally package --list, and all 23 Lune specs pass (7 new cases: string / Track / options-table lists, a bad element named by index, an empty list). The Open Cloud smoke runs on environment approval.After merge: tag
v0.22.0(release workflow builds the.rbxm), thenwally publish.