Conversation
vtnphan
marked this pull request as ready for review
September 29, 2026 00:19
minh-biocommons
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
SBP-671 Remove fasta header spaces in samplesheet (WISPS workflow)
Changes
sanitize_filename()inapp/services/s3.py: strips any character outside[A-Za-z0-9._-]to_, falling back to"file"if empty; applied to S3 upload keys.build_gadi_input_path()(globus_transfer.py) now sanitizes the filename before building the Gadi input path.WispsSequenceItem.id(interaction_screening.py) now enforces the same^[A-Za-z0-9._-]+$pattern via Pydantic, rejecting unsafe IDs at the API boundary.How to Test
idcontaining[,], or spaces and confirm it's rejected with a validation error._.uv run pytest tests/test_schemas.py tests/test_services_s3.py— new tests cover the pattern validation and sanitizer.Type of change
Checklist