Conversation
credit deduction for WISPS workflows
vtnphan
marked this pull request as ready for review
September 29, 2026 23:06
amandazhuyilan
approved these changes
Sep 29, 2026
amandazhuyilan
left a comment
Collaborator
There was a problem hiding this comment.
Nice fix - promise me you will do a test once this goes into dev?
Collaborator
Author
Yes, sure thing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
SBP-660
interaction-screeningandbulk-prediction(WISPS) launches never deducted credits —launch_credit_cost()only pricedsingle-prediction/de-novo-designand returnedNonefor the rest, so the deduction at launch was a silent no-op.Changes
launch_credit_cost()(credits.py) now prices bulk-prediction (multiplier × entry count) and interaction-screening (multiplier × query count × target count)._count_wisps_samplesheet_entries()(workflows.py) to derive that quantity server-side from the samplesheet already staged for the run (via itsgroupcolumn), instead of trusting the client-suppliedfastaContent— keeps the charge non-spoofable.SbpCreditField(admin.py).How to Test
uv run pytest tests/test_routes_workflows.py— covers bulk/interaction-screening deduction and 402 rejection on insufficient credits.Type of change
Checklist