Fix macOS Appium log noise, emulator auto-launch, and iOS device detection#721
Conversation
…und errors in iOS and Android device info retrieval
…val, surface recent logs on failure, and improve device type detection logic.
🔎 ZeuZ PR ReviewOpen the full report in ZeuZ: Review findings and apply suggestions
Agent breakdown→ General ReviewStatus: ✅ Completed One regression risk stands out: the new fallback path for first-run device selection can bypass platform filtering and pick the wrong deployed device when local detection is empty. The rest of the changes look consistent with the stated goals and are mostly low-risk logging/environment improvements. → Security ReviewStatus: ✅ Completed No high-signal security issues found in the PR diff. The changes mainly redirect noisy subprocess output to log files and improve device/emulator selection logic without introducing a clear auth, injection, or secret-handling regression. → Performance ReviewStatus: ✅ Completed Found one resource-usage issue: the new Appium log redirection opens a file handle for every server launch but never closes it in the parent process, which can leak descriptors across repeated runs. I also noted an optional optimization opportunity in emulator SDK root resolution, but it is lower priority. → Testing ReviewStatus: ✅ Completed The PR changes core device-selection and emulator-launch behavior, but the existing test suite does not cover the new regression paths. I found two high-signal gaps: Android emulator SDK/image resolution and the Appium/iOS device-detection/log-surfacing paths.
|
Summary
Fixes several macOS-specific mobile automation issues (some introduced by #720), without changing the working Windows/Linux behavior.
Files
Note
The xcodebuild code 70 during iOS bring-up was environmental (missing iOS simulator platform for Xcode), not a code issue — now visible in the console via the error-surfacing change.