Skip to content

Dash Item: remove the inert status and statusText props - #52405

Merged
CGastrell merged 2 commits into
trunkfrom
fix/jetpack-2550-dash-item-inert-props
Sep 17, 2026
Merged

Dash Item: remove the inert status and statusText props#52405
CGastrell merged 2 commits into
trunkfrom
fix/jetpack-2550-dash-item-inert-props

Conversation

@CGastrell

@CGastrell CGastrell commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Fixes JETPACK-2550

Proposed changes

DashItem declares two props it never reads. This removes both, and the data flow that existed only to feed them.

  • status stopped being read when #52058 removed the unreachable module="manage" branch, its last consumer. Eight At-a-Glance cards still computed values for it: akismet, monitor, photon, videopress and protect passed literals, while backups, scan and search forwarded it through a renderCard() helper fed by object literals.
  • statusText is inert for a different reason and from a different history — declared in propTypes, read nowhere in the component, and never set by any call site in _inc/client.

Removing status orphaned one prop upstream: backups.jsx's isVaultPressInstalled existed only to choose between 'pro-inactive' and 'pro-uninstalled'. With the status line gone it has no reader, so its propTypes, defaultProps, getVPContent() destructure, connect() selector entry and the now-unused isPluginInstalled import go with it.

scan.jsx has an identically-named isVaultPressInstalled prop that is live — it drives a real branch — and is left alone.

No user-facing change: none of these values reached the rendered output.

Related product discussion/links

Does this pull request change what data or activity we track or use?

No.

Testing instructions

The change is a removal of values that were never rendered, so the test is that At a Glance is unchanged.

  • Go to Jetpack → Dashboard (admin.php?page=jetpack#/dashboard) on a connected site.
  • Every At-a-Glance card renders as on trunk: Akismet, Backups, Monitor, Photon, Protect, Scan, Search, VideoPress. Check both an active and an inactive state for at least one card.
  • The Backups card is the one worth a closer look, since it lost a prop: confirm its paid/unpaid and VaultPress-installed/not-installed states still render the same content as trunk.
  • pnpm jetpack test js plugins/jetpack passes: 932 extensions tests, 493 + 509 admin-page tests (2 pre-existing skips).

🤖 Generated with Claude Code

CGastrell and others added 2 commits September 16, 2026 14:29
@CGastrell @claude
Dash Item: remove the inert status prop
ccc9f23 
DashItem's status prop stopped being read when PR #52058 removed the
unreachable module="manage" branch, its last consumer. Remove the prop
and the values every At-a-Glance card computed only to feed it.

Backups also drops isVaultPressInstalled: it existed only to compute
one of those status values.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@CGastrell @claude
Dash Item: remove the inert statusText prop
c1f6950 
Declared in propTypes, read nowhere in the component, and never set by
any call site in _inc/client. Separate from the status prop removed in
the previous commit, which became inert for a different reason.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@CGastrell CGastrell added [Status] Needs Review This PR is ready for review. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels Sep 16, 2026
@CGastrell CGastrell self-assigned this Sep 16, 2026
@github-actions

github-actions Bot commented Sep 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the fix/jetpack-2550-dash-item-inert-props branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack fix/jetpack-2550-dash-item-inert-props

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions Bot added [Tests] Includes Tests Admin Page React-powered dashboard under the Jetpack menu Docs labels Sep 16, 2026
@github-actions

github-actions Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen as soon as you deploy your changes after merging this PR (PCYsg-Jjm-p2).
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly:
    • Scheduled release: October 6, 2026

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@jp-launch-control

jp-launch-control Bot commented Sep 16, 2026

Copy link
Copy Markdown

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

@CGastrell
CGastrell requested a lite review from Copilot September 17, 2026 12:22
Copilot AI reviewed Sep 17, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No unresolved review issues were identified.

Pull request overview

Removes unused DashItem status props and obsolete data flow without changing rendered behavior.

Changes:

  • Removes inert props, call-site plumbing, tests, and documentation.
  • Cleans up unused Backups VaultPress state.
  • Records the internal cleanup in the changelog.
File summaries
File Summary
projects/plugins/jetpack/changelog/jetpack-2550-dash-item-status Records the cleanup.
projects/plugins/jetpack/_inc/client/components/dash-item/test/component.jsx Removes obsolete test props.
projects/plugins/jetpack/_inc/client/components/dash-item/README.md Updates component documentation.
projects/plugins/jetpack/_inc/client/components/dash-item/index.jsx Removes unused prop declarations.
projects/plugins/jetpack/_inc/client/at-a-glance/videopress.jsx Removes unused status plumbing.
projects/plugins/jetpack/_inc/client/at-a-glance/search.jsx Removes unused status plumbing.
projects/plugins/jetpack/_inc/client/at-a-glance/scan.jsx Removes obsolete status data while retaining live VaultPress logic.
projects/plugins/jetpack/_inc/client/at-a-glance/protect.jsx Removes unused status plumbing.
projects/plugins/jetpack/_inc/client/at-a-glance/photon.jsx Removes unused status plumbing.
projects/plugins/jetpack/_inc/client/at-a-glance/monitor.jsx Removes unused status plumbing.
projects/plugins/jetpack/_inc/client/at-a-glance/backups.jsx Removes status flow and orphaned VaultPress state.
projects/plugins/jetpack/_inc/client/at-a-glance/akismet.jsx Removes unused status plumbing.
Review details
  • Files reviewed: 12/12 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@CGastrell
CGastrell merged commit d4fa5a0 into trunk Sep 17, 2026
85 of 87 checks passed
@CGastrell
CGastrell deleted the fix/jetpack-2550-dash-item-inert-props branch September 17, 2026 12:44
@github-actions github-actions Bot added this to the jetpack/16.3 milestone Sep 17, 2026
@github-actions github-actions Bot removed the [Status] Needs Review This PR is ready for review. label Sep 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees

@CGastrell CGastrell

Labels

Admin Page React-powered dashboard under the Jetpack menu Docs [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Tests] Includes Tests [Type] Janitorial

Projects

None yet

Milestone

jetpack/16.3

Development

Successfully merging this pull request may close these issues.

2 participants

@CGastrell