Skip to content

Notice: Drop the props @wordpress/ui removed to unblock the dependency update - #53408

Closed
Nikschavan wants to merge 1 commit into
renovate/wordpress-monorepofrom
update/ui-notice-announcements
Closed

Nikschavan wants to merge 1 commit into
renovate/wordpress-monorepofrom
update/ui-notice-announcements

Conversation

@Nikschavan

Copy link
Copy Markdown
Member

Fixes N/A

Proposed changes

  • The @wordpress/ui update in Update wordpress monorepo #53004 picks up UI: Remove automatic Notice announcements WordPress/gutenberg#82737, which removed the automatic announcement from Notice.Root together with its spokenMessage and politeness props. That fails Update wordpress monorepo #53004 on "Type checking", and on "JS tests" through the React unknown-prop console error and the tests that assert an announcement. Eslint: adopt @wordpress/use-recommended-components #48487 is based on Update wordpress monorepo #53004, so it is blocked by the same failures.
  • Remove spokenMessage and politeness from every Notice.Root, along with the comments that explained them. The two Publicize notices use the @wordpress/components Notice, whose API did not change, so they should be handled separately.
  • Where an existing test asserts an announcement on a dynamic notice, restore what Notice.Root used to do: call speak() when the message changes, assertive for errors and polite otherwise. This covers Backup (QueryError and the restore warnings), the Boost Overview errors, and the Premium Analytics PageNotice, StaleDataNotice and SectionSyncNotice failure. Boost and Premium Analytics now depend on @wordpress/a11y for this.
  • Following the migration guide, static notices are not announced. The Boost "Website is not publicly available" notice and the SectionSyncNotice syncing and pending states are now silent, and their tests check for that.
  • This PR is kept small on purpose, so Update wordpress monorepo #53004 can merge. Choosing politeness by urgency rather than intent, moving speak() into the handlers that own each update, leaving technical details out of QueryError, and announcing the notices that are now silent are left for a follow-up against trunk.

Related product discussion/links

Does this pull request change what data or activity we track or use?

No.

Testing instructions

  • Nothing to test by hand for most of this. On this PR, "Type checking" should show no Notice.Root errors, and "JS tests" should have no spokenMessage console errors or failing announcement tests, where Update wordpress monorepo #53004 has both.
  • To hear an announcement, check out this branch, build Boost (jp build plugins/boost --deps), and open Jetpack → Boost with a screen reader running. Make the speed score request fail (for example, block requests matching speed-scores in the browser's network tools, then reload) and confirm that "Failed to load speed scores" is announced once.
  • I ran typecheck and the JS tests for Backup, Boost, Newsletter, Premium Analytics, Search, VideoPress and the Jetpack AI screens. I did not test speech in a browser.

@wordpress/ui no longer announces Notice.Root content or accepts spokenMessage/politeness (WordPress/gutenberg#82737). Remove the props, and restore the old speak() behaviour only for dynamic notices whose tests assert an announcement, so the dependency update can merge. The full migration follows separately.
@Nikschavan Nikschavan self-assigned this Oct 9, 2026
@github-actions github-actions Bot added [Extension] AI Assistant Plugin [mu wpcom Feature] Ai Launchpad [Package] Backup [Package] Jetpack mu wpcom WordPress.com Features [Package] Newsletter [Package] Premium Analytics [Package] Search Contains core Search functionality for Jetpack and Search plugins [Package] VideoPress [Plugin] Boost A feature to speed up the site and improve performance. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. Admin Page React-powered dashboard under the Jetpack menu labels Oct 9, 2026
@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Jetpack plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.


Boost plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.


Protect plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@Nikschavan Nikschavan closed this Oct 9, 2026
@Nikschavan
Nikschavan deleted the update/ui-notice-announcements branch October 9, 2026 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Admin Page React-powered dashboard under the Jetpack menu [Extension] AI Assistant Plugin [mu wpcom Feature] Ai Launchpad [Package] Backup [Package] Jetpack mu wpcom WordPress.com Features [Package] Newsletter [Package] Premium Analytics [Package] Search Contains core Search functionality for Jetpack and Search plugins [Package] VideoPress [Plugin] Boost A feature to speed up the site and improve performance. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant