Repository navigation
Notice: Drop the props @wordpress/ui removed to unblock the dependency update - #53408
Nikschavan wants to merge 1 commit into
Conversation
@wordpress/ui no longer announces Notice.Root content or accepts spokenMessage/politeness (WordPress/gutenberg#82737). Remove the props, and restore the old speak() behaviour only for dynamic notices whose tests assert an announcement, so the dependency update can merge. The full migration follows separately.
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Jetpack plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Boost plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Protect plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Fixes N/A
Proposed changes
@wordpress/uiupdate in Update wordpress monorepo #53004 picks up UI: Remove automatic Notice announcements WordPress/gutenberg#82737, which removed the automatic announcement fromNotice.Roottogether with itsspokenMessageandpolitenessprops. That fails Update wordpress monorepo #53004 on "Type checking", and on "JS tests" through the React unknown-prop console error and the tests that assert an announcement. Eslint: adopt@wordpress/use-recommended-components#48487 is based on Update wordpress monorepo #53004, so it is blocked by the same failures.spokenMessageandpolitenessfrom everyNotice.Root, along with the comments that explained them. The two Publicize notices use the@wordpress/componentsNotice, whose API did not change, so they should be handled separately.Notice.Rootused to do: callspeak()when the message changes, assertive for errors and polite otherwise. This covers Backup (QueryErrorand the restore warnings), the Boost Overview errors, and the Premium AnalyticsPageNotice,StaleDataNoticeandSectionSyncNoticefailure. Boost and Premium Analytics now depend on@wordpress/a11yfor this.SectionSyncNoticesyncing and pending states are now silent, and their tests check for that.speak()into the handlers that own each update, leaving technical details out ofQueryError, and announcing the notices that are now silent are left for a follow-up against trunk.Related product discussion/links
Does this pull request change what data or activity we track or use?
No.
Testing instructions
Notice.Rooterrors, and "JS tests" should have nospokenMessageconsole errors or failing announcement tests, where Update wordpress monorepo #53004 has both.jp build plugins/boost --deps), and open Jetpack → Boost with a screen reader running. Make the speed score request fail (for example, block requests matchingspeed-scoresin the browser's network tools, then reload) and confirm that "Failed to load speed scores" is announced once.