Repository navigation
Document signed commits and merge-commit-only PRs - #163
Merged
Merged
Conversation
Both rulesets now reject unsigned commits, so contributors need to know before they open a pull request rather than discover it when the merge button is blocked. The agent guidance still said to squash and merge, which the repository no longer allows. Refs VIPPLUG-173.
GaryJones
force-pushed
the
GaryJones/vipplug-173-review
branch
from
October 9, 2026 07:20
2574f49 to
574b2a3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
developandmainrulesets now reject unsigned commits, and the repository only allows merge commits (squash and rebase merging are both disabled). Neither was written down anywhere a contributor would see it, so the first anyone would learn of the signing requirement is a blocked merge button on an otherwise ready PR.CONTRIBUTING.mdnow tells contributors to sign their commits and links to GitHub's guide, using the same wording as the other VIP plugin repos.AGENTS.mdstill told agents to squash and merge, which the repository no longer permits, so that line now describes the merge-commit workflow instead.Refs VIPPLUG-173.