chore(port): forward-port v5-next secp256r1 soundness fix to next#24936
Merged
Conversation
(cherry picked from commit c6ab912)
Replace the secp256r1-specific unique/positive table_index test with one that sweeps every basic table reachable through any MultiTable. The LogDeriv relation identifies a table solely by table_index, so this guards against any generator (not just secp256r1 fixed-base) storing a window or bit-slice position in place of the builder-assigned index. (cherry picked from commit 3a53c97)
(cherry picked from commit f013e44)
iakovenkos
approved these changes
Jul 24, 2026
PhilWindle
enabled auto-merge
July 24, 2026 13:34
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 24, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward-ports the barretenberg secp256r1 unique-lookup-index soundness fix to
next— missed by the initial area-bucketed sweep because its PR-numbered wrapper (#24842) is a merge commit and its content commits carry no(#N)suffix (they arrived via merge PR #647), so both the--no-mergesand(#N)filters dropped them.Applied (clean cherry-picks, chronological)
c6ab912228fix(bb): assign unique secp256r1 lookup table indices3a53c977e4test(bb): generalize lookup table-index invariant across all tablesf013e4497fcomment cleanupCorresponds to v5-next #24842. Part of the manual v5-next → next backlog sweep.