Replace Dism commands with Repair-WindowsImage#325
Open
Karl-WE wants to merge 1 commit into
Open
Conversation
Replacing all cmdline dism commands with PowerShell dism module, which comes integrated into the OS works with PS5.1 and 7.x likewise. Staying in PowerShell syntax is cleaner and more efficient as there as less characters to type and it offers autocompletion. Output / Progress / eventually piping.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR replaces command-line Dism.exe invocations with the DISM PowerShell module's Repair-WindowsImage cmdlet in the "System Drive Free Space" troubleshooting guide, with the stated goal of staying in PowerShell syntax that works on both PS 5.1 and 7.x. While the intent (a consistent PowerShell experience) is reasonable, the specific cmdlet parameters chosen do not map to the original DISM operations, which breaks the documented commands.
Changes:
- Replaced
/AnalyzeComponentStorewithRepair-WindowsImage -Online -ScanHealth(different operation). - Replaced two
/StartComponentCleanupcalls withRepair-WindowsImage -Online -StartComponentCleanup(unsupported parameter). - Left the surrounding exit-code reporting logic (
$LASTEXITCODE) unchanged, which no longer applies to cmdlet output.
|
|
||
| # How much the Windows component store (WinSxS) can reclaim | ||
| Dism.exe /Online /Cleanup-Image /AnalyzeComponentStore | ||
| Repair-WindowsImage -Online -ScanHealth |
Author
There was a problem hiding this comment.
I am a bit baffled that this is the second command, found missing in dism module now. The other one is a specific compression methods for exporting images (Export-WindowsImage). 🤔
Asking internally on DL.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replacing all cmdline dism commands with PowerShell dism module, which comes integrated into the OS works with PS5.1 and 7.x likewise.
Staying in PowerShell syntax is cleaner and more efficient as there as less characters to type and it offers autocompletion. Output / Progress / eventually piping.