table store batch to reject batches with different partitionkeys - #2333
Open
Kent Inge Fagerland Simonsen (kentis) wants to merge 2 commits into
Conversation
…s in a batch when processing batch table operations
Collaborator
|
Reviewing |
Edwin Huber (edwin-huber)
self-requested a review
January 8, 2024 07:54
Edwin Huber (edwin-huber)
added
the
table-storage
Contributor
|
Feel free to let me know if you need any assistance on this PR reviewing. |
Edwin Huber (edwin-huber)
requested changes
Jan 18, 2024
| batchContextClone: any | ||
| ) { | ||
| if (this.partitionKeyMap.size > 0) { | ||
| console.log("checking for differing partition keys"); |
Collaborator
There was a problem hiding this comment.
please remove console.log calls
| }); | ||
|
|
||
| //Skips this test because it requires modifying the Azure Data Tables client so that it does not perform a check for partition key consistency before submitting the batch. | ||
| it.skip("10. Batch API should fail when attempting to insert elements with different partitionkeys in same batch, @loki", async () => { |
Collaborator
There was a problem hiding this comment.
Please look at the table.entity.rest.test.ts file, there is an example of a batch request in there, which you can use to simulate this request.
Collaborator
There was a problem hiding this comment.
I am just updating the tests, which should make this easier for you
Collaborator
There was a problem hiding this comment.
It is taking a while to convert all the REST tests to the new method and remove dependencies, hope to be done by the end of the week.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for contribution! Please go through following checklist before sending PR.
This PR fixes issue #1215
PR Branch Destination
mainbranch.legacy-devbranch.Always Add Test Cases
Test case is added but skipped since it requires modifications to the azure table client dependency to run properly. This is because the client perform the same check. This is, howevernot true for all clients.
Add Change Log
Add change log for the code change in
Upcoming Releasesection inChangeLog.md.Development Guideline
Please go to CONTRIBUTION.md for steps about setting up development environment and recommended Visual Studio Code extensions.