Adding fix for issue #1967 - #2404
Conversation
|
blperf please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
|
/azp run |
|
|
||
| private circularStreamsBuffer: FileLazyReadStream[]; | ||
|
|
||
| private maxStreams = 100000; |
There was a problem hiding this comment.
Could you share how you select this number?
|
Mainly the change looks good to me. We may need to do some test first blperf blperf , it'd be really helpful if you could share tests you have done. |
|
Tried with downloading a 8G file multiple times, but seems still meet the hang issue. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Thanks for contribution! Please go through following checklist before sending PR.
PR Branch Destination
mainbranch.legacy-devbranch.Always Add Test Cases
Make sure test cases are added to cover the code change.
Add Change Log
Add change log for the code change in
Upcoming Releasesection inChangeLog.md.Development Guideline
Please go to CONTRIBUTION.md for steps about setting up development environment and recommended Visual Studio Code extensions.