Bump cross-env from 7.0.3 to 10.1.0 - #2717
Conversation
Bumps [cross-env](https://github.com/kentcdodds/cross-env) from 7.0.3 to 10.1.0. - [Release notes](https://github.com/kentcdodds/cross-env/releases) - [Changelog](https://github.com/kentcdodds/cross-env/blob/main/CHANGELOG.md) - [Commits](kentcdodds/cross-env@v7.0.3...v10.1.0) --- updated-dependencies: - dependency-name: cross-env dependency-version: 10.1.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
There was a problem hiding this comment.
Pull request overview
Note
Copilot could not run the full agentic suite for this review because it was automatically requested on a bot-authored pull request. Request a review from Copilot under Reviewers to retry with the full agentic suite. Improved support for bot-authored pull requests is coming soon.
Updates the project’s development dependencies by bumping cross-env to a newer major version.
Changes:
- Upgrade
cross-envfrom^7.0.3to^10.1.0
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
…elog Co-authored-by: jainakanksha-msft <181211853+jainakanksha-msft@users.noreply.github.com>
Addressed in 916374d:
Rating: 10/10 — build, lint, and the affected test suite all pass, and the fix is scoped to the actual regression caused by the bump. |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 4 changed files in this pull request and generated no new comments.
Suppressed comments (2)
ChangeLog.md:34
- This changelog entry says the test resolves
cross-env-shellvia thenode_modules/.binsymlink. If the test is updated to use the actual JS entrypoint (to avoid Windows .bin shims), this line should be updated to match the new resolution strategy so the release notes remain accurate.
- Bumped `cross-env` dev dependency from `^7.0.3` to `^10.1.0`. Cross-env 10 is ESM-only and moved its bin scripts from `src/bin/` to `dist/bin/`; updated `tests/packageScripts.test.ts` to resolve the `cross-env-shell` binary via the `node_modules/.bin` symlink instead of `require.resolve("cross-env/src/bin/cross-env-shell.js")`, which no longer resolves under the package's new `exports` map.
tests/packageScripts.test.ts:25
node_modules/.bin/cross-env-shellis an npm-generated shim/symlink intended to be executed directly by the OS. In this test it is being passed tonodeas if it were a JS file (spawnSync(process.execPath, [crossEnvShell, ...])), which is likely to fail on Windows where the .bin entry is typically a.cmd/shim rather than the JS entrypoint. Resolve the actual JS bin script (dist/bin/cross-env-shell.js) and pass that tonodeinstead.
// cross-env 10 is an ESM-only package with an "exports" map that doesn't
// expose a "require" condition, so require.resolve() can't be used to
// locate the bin script. Resolve it the same way npm does: through the
// generated node_modules/.bin symlink.
const crossEnvShell = fs.realpathSync(
Copilot |
Co-authored-by: jainakanksha-msft <181211853+jainakanksha-msft@users.noreply.github.com>
... Addressed in 966360d: |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 4 changed files in this pull request and generated no new comments.
Suppressed comments (1)
tests/packageScripts.test.ts:26
- This test now hard-codes cross-env's internal file layout (dist/bin/...) rather than using the package's declared
binmapping. That makes the test more likely to break on future cross-env refactors even if the CLI contract remains stable. Consider resolving the script path from cross-env's package.jsonbin["cross-env-shell"], with a fallback to the current path.
const crossEnvShell = path.resolve(
__dirname,
"../node_modules/cross-env/dist/bin/cross-env-shell.js"
);
Copilot, please check this suppressed comment |
Co-authored-by: jainakanksha-msft <181211853+jainakanksha-msft@users.noreply.github.com>
... Addressed in 8b60e35: |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 4 changed files in this pull request and generated no new comments.
Suppressed comments (1)
tests/packageScripts.test.ts:34
- The fallback to "dist/bin/cross-env-shell.js" reintroduces hard-coding of cross-env’s internal file layout, which the preceding comment says we’re trying to avoid. It can also mask upstream changes to the public bin mapping (the test would keep passing even if the bin entry moved/was removed). Consider validating that the package’s declared bin map contains "cross-env-shell" and failing with a clear message if it doesn’t.
const crossEnvShell = path.resolve(
path.dirname(crossEnvPackageJsonPath),
crossEnvPackageJson.bin?.["cross-env-shell"] ??
"dist/bin/cross-env-shell.js"
);
Copilot, please check this suppressed comment |
… entry with clear error Co-authored-by: jainakanksha-msft <181211853+jainakanksha-msft@users.noreply.github.com>
... Fixed in the latest commit: removed the |
Bumps cross-env from 7.0.3 to 10.1.0.
Release notes
Sourced from cross-env's releases.
Commits
152ae6afeat: add support ofr default value syntaxbd70d1achore: upgrade zshy8e0b190chore(ci): get coverage8635e80fix(release): manually release a major version3a58f22chore: fix npmrc registryb70bfffchore(ci): add names to steps and workflowscc5759dfix(release): manually release a major version080a859chore: remove publish script31e5bc7chore(ci): restore built files81e9c34chore(ci): add back semantic-releaseDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)