Bump multistream and @types/multistream - #2718
Conversation
Bumps [multistream](https://github.com/feross/multistream) and [@types/multistream](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/multistream). These dependencies needed to be updated together. Updates `multistream` from 2.1.1 to 4.1.0 - [Commits](feross/multistream@v2.1.1...v4.1.0) Updates `@types/multistream` from 2.1.2 to 4.1.4 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/multistream) --- updated-dependencies: - dependency-name: multistream dependency-version: 4.1.0 dependency-type: direct:production update-type: version-update:semver-major - dependency-name: "@types/multistream" dependency-version: 4.1.4 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
There was a problem hiding this comment.
Pull request overview
Note
Copilot could not run the full agentic suite for this review because it was automatically requested on a bot-authored pull request. Request a review from Copilot under Reviewers to retry with the full agentic suite. Improved support for bot-authored pull requests is coming soon.
Updates the multistream dependency and its TypeScript typings to newer major versions.
Changes:
- Bump
multistreamfrom^2.1.1to^4.1.0 - Bump
@types/multistreamfrom^2.1.1to^4.1.4
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Co-authored-by: jainakanksha-msft <181211853+jainakanksha-msft@users.noreply.github.com>
Addressed in 16e15a6:
|
|
Copilot, |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 7 changed files in this pull request and generated no new comments.
Suppressed comments (2)
ChangeLog.md:29
- ChangeLog entry says
@types/multistreamwas bumped from^2.1.2, but the previous package.json dependency range was^2.1.1(the lockfile resolved to 2.1.2). This release note should reflect the actual declared range to avoid confusion when auditing dependency changes.
- Bumped `multistream` from `^2.1.1` to `^4.1.0` and `@types/multistream` from `^2.1.2` to `^4.1.4`. Updated `FSExtentStore.readExtents()` and `MemoryExtentStore.readExtents()` to call `multistream` with `new` (now a class in v4) and added unit test coverage for merging multiple extents into a single stream.
tests/blob/fsStore.test.ts:82
- This new unit test creates on-disk extents under the default
__blobstorage__folder but never closes/cleans the store, which can leave test artifacts in the repo working directory and potentially keep file handles open. Wrap the test in a try/finally and callstore.close()+store.clean()(clean requires close) so the test suite is self-cleaning.
it("should merge multiple extents into a single readable stream @loki", async () => {
const store = new FSExtentStore(metadataStore, DEFAULT_BLOB_PERSISTENCE_ARRAY, logger);
await store.init();
const extent1 = await store.appendExtent(Buffer.from("Hello"));
Co-authored-by: jainakanksha-msft <181211853+jainakanksha-msft@users.noreply.github.com>
Addressed in c617786. The intent is exactly that the behavior stays the same across the upgrade: these tests pass on the pre-upgrade behavior and on the fixed branch, but they fail on the intermediate broken dependency-bump commit because I also added another scenario in both extent-store implementations to cover a ranged read that spans extent boundaries, so the coverage is now:
Validated with |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 7 changed files in this pull request and generated no new comments.
Suppressed comments (1)
ChangeLog.md:29
- ChangeLog entry says
@types/multistreamwas bumped from^2.1.2, butpackage.jsonshows the previous range was^2.1.1. This makes the release note inconsistent with the actual dependency change.
- Bumped `multistream` from `^2.1.1` to `^4.1.0` and `@types/multistream` from `^2.1.2` to `^4.1.4`. Updated `FSExtentStore.readExtents()` and `MemoryExtentStore.readExtents()` to call `multistream` with `new` (now a class in v4) and added unit test coverage for merging multiple extents into a single stream.
30917cf
into
main
Bumps multistream and @types/multistream. These dependencies needed to be updated together.
Updates
multistreamfrom 2.1.1 to 4.1.0Commits
aef3ef74.1.039ccbf4fix syntax errord3ee23cMerge branch 'master' into refactor-streamsf5c89faUpdate index.jsd6c91b2standard9da6051package metadatae43177c4.0.1616ef60bump deps16eb694Merge pull request #52 from feross/greenkeeper/airtap-3.0.05a59a1eMerge pull request #53 from feross/greenkeeper/tape-5.0.0Updates
@types/multistreamfrom 2.1.2 to 4.1.4Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)