Bump eslint from 8.57.1 to 10.8.0 - #2720
Conversation
Bumps [eslint](https://github.com/eslint/eslint) from 8.57.1 to 10.8.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Commits](eslint/eslint@v8.57.1...v10.8.0) --- updated-dependencies: - dependency-name: eslint dependency-version: 10.8.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
There was a problem hiding this comment.
Pull request overview
Note
Copilot could not run the full agentic suite for this review because it was automatically requested on a bot-authored pull request. Request a review from Copilot under Reviewers to retry with the full agentic suite. Improved support for bot-authored pull requests is coming soon.
Updates the project’s linting toolchain by bumping the eslint dev dependency to a newer major version.
Changes:
- Upgraded
eslintfrom^8.57.1to^10.8.0
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
…date ChangeLog Co-authored-by: jainakanksha-msft <181211853+jainakanksha-msft@users.noreply.github.com>
Here's a summary of the work done:
Commit: Migrate ESLint config to flat config format for v10 compatibility, update ChangeLog |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 5 changed files in this pull request and generated no new comments.
Suppressed comments (1)
eslint.config.js:16
- The TS flat-config block relies on inherited defaults for ecmaVersion/sourceType. To avoid fragile behavior (and potential parse errors for ES module
import/exportif defaults change), set parserOptions explicitly for the@typescript-eslintparser.
parser: tsParser,
globals: {
...globals.node,
},
},
|
…ment, no-constant-binary-expression, no-unreachable) Co-authored-by: jainakanksha-msft <181211853+jainakanksha-msft@users.noreply.github.com>
Fixed the CI build issues. ESLint v10 introduced three new rules that weren't in v8:
Added all three to the disabled rules in This is a dev tooling change (linter upgrade) — no production logic was altered, so no test case additions are needed. The existing test suite validates the change since Commit: Fix CI lint failures: disable new ESLint v10 rules |
|
Copilot, |
|
Akanksha Jain (@jainakanksha-msft) I've opened a new pull request, #2721, to work on those changes. Once the pull request is ready, I'll request review from you. |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 5 changed files in this pull request and generated no new comments.
Suppressed comments (1)
ChangeLog.md:24
- The new ESLint v10 dependency chain requires Node.js "^20.19.0 || ^22.13.0 || >=24" (see package-lock.json around the eslint entry), but package.json currently allows ">=22.0.0". That means Node 22.0–22.12 satisfies your declared engine but is outside ESLint’s supported range, which can cause install failures/warnings in environments honoring engines. Consider tightening package.json engines.node to ">=22.13.0" (or otherwise aligning it with the new ESLint engine constraint).
- Bumped `eslint` dev dependency from 8.57.1 to 10.8.0 and migrated ESLint configuration from legacy `.eslintrc.js` to the flat config format (`eslint.config.js`) required by ESLint v9+. Added `@eslint/js` and `globals` as dev dependencies to support the flat config.
Copilot, I don't feel this suppressed comment is that much valid, because we can set any version in package.json, other EsLint10 is also supported by 20.19.0. so that's why current definition looks fine to me. |
... I agree this suppressed note is not a blocker for this PR.
If we want stricter engine alignment specifically for tooling constraints, that should be handled as a separate discussion/PR. |
Bumps eslint from 8.57.1 to 10.8.0.
Release notes
Sourced from eslint's releases.
... (truncated)
Commits
749dfed10.8.04bd0d75Build: changelog update for 10.8.04fbf46dtest: pinwebpackversion to 5.108.4 (#21137)6ddf858docs: fix broken Specify Parser Options anchor link (#21106)784dfbedocs: Clarifyno-eq-nulldescription (#21120)6b8d2f7fix: escape reserved characters in rule id inhtmlformatter (#21129)2d063e2chore: update HTTP URLs to HTTPS in JSDoc and comments (#21101)eccbe7btest: add error locations tono-class-assign(#21123)2fee9bbfeat: exportConfigObjectfromeslint/config(#21082)e7d1e43ci: bump actions/setup-go from 6 to 7 (#21118)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)