Route dependency restores through Central Feed Service - #1382
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR centralizes dependency restore configuration so NuGet and npm traffic is routed through the Azure Artifacts “upstream-public” feed, and updates CI definitions to consistently use those repo-scoped configs (plus a small GitHub Actions quoting fix).
Changes:
- Add repo-root
NuGet.configthat clears inherited sources and maps all packages toazfunc/public/upstream-public; remove the legacy.nuget/NuGet.Config. - Update Azure Pipelines
DotNetCoreCLI@2restore steps to explicitly use the repoNuGet.config. - Route the Azurite global npm install through an authenticated, CI-only
.npmrc, and fix quoting for the CodeQL workflow’s Windowsdotnetcommands.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
NuGet.config |
New root NuGet source + mapping configuration targeting the upstream-public feed. |
eng/templates/build.yml |
Restore step now explicitly uses the repo NuGet.config. |
eng/templates/build-steps.yml |
Restore steps now explicitly use the repo NuGet.config (including test restore). |
eng/templates/test.yml |
Adds npm authentication and forces Azurite install to use the CI .npmrc. |
eng/templates/.npmrc |
Adds a CI-scoped npm registry configuration pointing to upstream-public (scoped registries + default). |
.nuget/NuGet.Config |
Removes the legacy NuGet config now replaced by the repo-root NuGet.config. |
.github/workflows/codeQL.yml |
Quotes and corrects Windows dotnet restore/build solution argument usage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
berndverst
approved these changes
Aug 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
azfunc/public/upstream-publicDotNetCoreCLI@2restore explicitly use the repository config.npmrc, including explicit mappings for all ten scopes in its resolved transitive graphValidation
pkgs.dev.azure.comfor NuGet requests and no direct nuget.org trafficpackages.configproject through CFS only, includingMicrosoft.VisualStudio.Azure.Fabric.MSBuild, using quoted Windows argument arrays and paths containing spacesNPM_CONFIG_USERCONFIG; request logs contain only CFS/Azure Artifacts blob hosts and no direct npm registry requests.npmrc,NuGet.config, credentials, lockfiles, ornode_modulesSystem.Net.HttpandSystem.Text.RegularExpressionsadvisories, then exits nonzero becausedotnet list packagedoes not support the repository's legacypackages.configService Fabric projectPython/pip/uv and repository package.json/lockfile surfaces are absent, so no configuration was added for them.