expand reference to resolve conflict - #360
Merged
Chrisshort92 merged 1 commit intoSep 7, 2026
Merged
Chrisshort92 merged 1 commit into
Chrisshort92 merged 1 commit into
Conversation
Contributor
Author
|
@BHoMBot check required |
|
@Chrisshort92 to confirm, the following actions are now queued:
There are 7 requests in the queue ahead of you. |
Contributor
Author
|
@BHoMBot check copyright-compliance |
|
@Chrisshort92 to confirm, the following actions are now queued:
There are 21 requests in the queue ahead of you. |
Contributor
Author
|
@BHoMBot check dataset-compliance |
|
@Chrisshort92 to confirm, the following actions are now queued:
There are 23 requests in the queue ahead of you. |
GCRA101
approved these changes
Sep 7, 2026
GCRA101
left a comment
Contributor
There was a problem hiding this comment.
Tested changes to code using the provided Grasshopper Test File and all works as expected. Approved.
Contributor
Author
|
@BHoMBot check ready-to-merge |
|
@Chrisshort92 to confirm, the following actions are now queued:
There are 9 requests in the queue ahead of you. |
Chrisshort92
deleted the
SAP2000_Toolkit-#359-expand-reference-to-resolve-conflict
branch
September 7, 2026 11:42
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: Depends on
Issues addressed by this PR
Closes #359
Expanded single Query reference to its full path to resolve conflict between Geometry.Query() & Units.Query(). New Units.Query() method added in Localisation_Toolkit introduces this conflict.
BHoM/Localisation_Toolkit#181
if (Query.IsParallel(normal, Vector.ZAxis)!=0)now reads
if (BH.Engine.Geometry.Query.IsParallel(normal, Vector.ZAxis)!=0)Test files
https://burohappold.sharepoint.com/:f:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/SAP2000_Toolkit/%23360-ExpandReferenceToResolveConflict?d=wfdb3817de2054fb38a5ce621ed661e1e&csf=1&web=1&e=qPHmca
Changelog
Additional comments