Skip to content

expand reference to resolve conflict - #360

Merged
Chrisshort92 merged 1 commit into
developfrom
SAP2000_Toolkit-#359-expand-reference-to-resolve-conflict
Sep 7, 2026
Merged

Chrisshort92 merged 1 commit into
developfrom
SAP2000_Toolkit-#359-expand-reference-to-resolve-conflict

Conversation

@Chrisshort92

@Chrisshort92 Chrisshort92 commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

NOTE: Depends on

Issues addressed by this PR

Closes #359

Expanded single Query reference to its full path to resolve conflict between Geometry.Query() & Units.Query(). New Units.Query() method added in Localisation_Toolkit introduces this conflict.

BHoM/Localisation_Toolkit#181

if (Query.IsParallel(normal, Vector.ZAxis)!=0)

now reads

if (BH.Engine.Geometry.Query.IsParallel(normal, Vector.ZAxis)!=0)

Test files

https://burohappold.sharepoint.com/:f:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/SAP2000_Toolkit/%23360-ExpandReferenceToResolveConflict?d=wfdb3817de2054fb38a5ce621ed661e1e&csf=1&web=1&e=qPHmca

Changelog

Additional comments

@Chrisshort92

Copy link
Copy Markdown
Contributor Author

@BHoMBot check required

@bhombot-ci

bhombot-ci Bot commented Sep 6, 2026

Copy link
Copy Markdown

@Chrisshort92 to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 7 requests in the queue ahead of you.

@Chrisshort92 Chrisshort92 added the type:bug Error or unexpected behaviour label Sep 6, 2026
@Chrisshort92

Copy link
Copy Markdown
Contributor Author

@BHoMBot check copyright-compliance

@bhombot-ci

bhombot-ci Bot commented Sep 6, 2026

Copy link
Copy Markdown

@Chrisshort92 to confirm, the following actions are now queued:

  • check copyright-compliance

There are 21 requests in the queue ahead of you.

@Chrisshort92

Copy link
Copy Markdown
Contributor Author

@BHoMBot check dataset-compliance

@bhombot-ci

bhombot-ci Bot commented Sep 6, 2026

Copy link
Copy Markdown

@Chrisshort92 to confirm, the following actions are now queued:

  • check dataset-compliance

There are 23 requests in the queue ahead of you.

@GCRA101 GCRA101 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested changes to code using the provided Grasshopper Test File and all works as expected. Approved.

@Chrisshort92

Copy link
Copy Markdown
Contributor Author

@BHoMBot check ready-to-merge

@bhombot-ci

bhombot-ci Bot commented Sep 7, 2026

Copy link
Copy Markdown

@Chrisshort92 to confirm, the following actions are now queued:

  • check ready-to-merge

There are 9 requests in the queue ahead of you.

@Chrisshort92
Chrisshort92 merged commit 14e20d3 into develop Sep 7, 2026
11 checks passed
@Chrisshort92
Chrisshort92 deleted the SAP2000_Toolkit-#359-expand-reference-to-resolve-conflict branch September 7, 2026 11:42
@BHoMBot BHoMBot mentioned this pull request Sep 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:bug Error or unexpected behaviour

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expand reference to resolve conflict

2 participants