Fix versioning for BH.oM.LadybugTools.SimulationResult - #355
Merged
peterjamesnugent merged 2 commits intoSep 16, 2026
Merged
Conversation
Contributor
Author
|
@Tom-Kingstone to confirm, the following actions are now queued:
|
jamesramsden-bh
approved these changes
Sep 16, 2026
jamesramsden-bh
left a comment
There was a problem hiding this comment.
Have tested alongside linked PR in LBT_TK, all good from me to merge
|
@Tom-Kingstone just to let you know, I have provided a |
peterjamesnugent
deleted the
Versioning_Toolkit-#354-SimulationResult
branch
September 16, 2026 16:00
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: Depends on
Issues addressed by this PR
Closes #354
See linked issue, this should fix the problem of unnecessarily applying the versioning for this object at least.
Test files
See PR in LadybugTools_Toolkit
Changelog
Additional comments