Skip to content

Fix versioning for BH.oM.LadybugTools.SimulationResult - #355

Merged
peterjamesnugent merged 2 commits into
developfrom
Versioning_Toolkit-#354-SimulationResult
Sep 16, 2026
Merged

peterjamesnugent merged 2 commits into
developfrom
Versioning_Toolkit-#354-SimulationResult

Conversation

@Tom-Kingstone

@Tom-Kingstone Tom-Kingstone commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor

NOTE: Depends on

Issues addressed by this PR

Closes #354

See linked issue, this should fix the problem of unnecessarily applying the versioning for this object at least.

Test files

See PR in LadybugTools_Toolkit

Changelog

Additional comments

@Tom-Kingstone Tom-Kingstone self-assigned this Sep 15, 2026
@Tom-Kingstone Tom-Kingstone added the type:bug Error or unexpected behaviour label Sep 15, 2026
@Tom-Kingstone

Copy link
Copy Markdown
Contributor Author

@BHoMBot check versioning
@BHoMBot check installer
@BHoMBot check core
@BHoMBot check copyright-compliance

@bhombot-ci

bhombot-ci Bot commented Sep 16, 2026

Copy link
Copy Markdown

@Tom-Kingstone to confirm, the following actions are now queued:

  • check versioning
  • check installer
  • check core
  • check copyright-compliance

@jamesramsden-bh jamesramsden-bh left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have tested alongside linked PR in LBT_TK, all good from me to merge

@bhombot-ci

bhombot-ci Bot commented Sep 16, 2026

Copy link
Copy Markdown

@Tom-Kingstone just to let you know, I have provided a check-ready-to-merge result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @Tom-Kingstone on LadybugTools_Toolkit

@peterjamesnugent
peterjamesnugent merged commit f421c34 into develop Sep 16, 2026
13 of 14 checks passed
@peterjamesnugent
peterjamesnugent deleted the Versioning_Toolkit-#354-SimulationResult branch September 16, 2026 16:00
@peterjamesnugent peterjamesnugent mentioned this pull request Sep 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:bug Error or unexpected behaviour

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use custom versioning method for SimulationResult Identifier property

3 participants