Repository navigation
Name the trigger in a name-less signal handler's error, and test untested command paths - #73
Merged
Merged
Conversation
…sted command paths
`on signal { }` reported "A message handler needs the message's name".
The handler check now names its own trigger, as the start-event and await checks already do.
The extension tests now cover open-and-decompile, declining the overwrite prompt, unsaved edits winning over the file on disk, and decompile with nothing selected.
The CLI tests now cover exit code 2 for a missing input, an unreadable input and an unwritable output.
CONTRIBUTING.md records why `.nvmrc` pins Node 24.19.0: 24.20.0 and 24.21.0 fail `langium generate` with `ERR_INVALID_URL`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
on signal { }without a name reported "A message handler needs the message's name: the engine matches messages by name."It now says "A signal handler needs the signal's name: the engine matches signals by name.", the same way the start-event and
awaitchecks already name their trigger.The extension tests now cover:
Open a BPMN file and convert it...with the dialog cancelled and with a file picked.Decompile to BPMNscriptwith no file selected.The CLI smoke tests now check exit code 2 for a missing input, an unreadable input and an unwritable output.
.nvmrcstays at24.19.0.I checked 24.21.0 and
langium generatestill fails there withERR_INVALID_URL.CONTRIBUTING.md now says why, so the pin isn't mistaken for an oversight.
The comment at the top of
ast-to-ir.tsnow also notes that the validator's reservedGateway_..._splitpattern is end-anchored, so a gateway id that picked up a_2collision suffix would slip past it.Gateway ids never go through
resolveCollisiontoday, so nothing breaks.Typecheck, lint, format check and the full test suite pass.