Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #631
the
dnloadandcopycompletion lines and the failed-action error line printed remote file names raw, so control characters reached the terminal. the other four action messages already escape.dnloadandcopynow useescape_control_charslike the rest. plain names print the same, names with spaces get quoted (dnload 'my file.txt'), same asuploadalready doesunprintable_to_hexinstead, so normal error lines don't get wrapped in shell quotestests in
test/unit/sync/test_sync_escaping.pyfail with the fix reverted. the error-path one runs v1+ since v0 wrapsIncompleteSyncinCommandError. couldn't run windows locally, the test name uses U+009B which ntfs allows so it should be fine there