Skip to content

fix(b2): stop a cancelled copy from writing after copyContext returns #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ffumero2003 merged 17 commits into from
Oct 30, 2026
Merged

fix(b2): stop a cancelled copy from writing after copyContext returns #236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
973d999
test(b2): reproduce writes after copy cancellation
ffumero2003 Oct 29, 2026
809a1fb
fix(b2): stop a cancelled copy from writing after copyContext returns
ffumero2003 Oct 29, 2026
73a3ae8
test(b2): match the abandoned-copy error with errors.Is and document …
ffumero2003 Oct 29, 2026
6672425
Merge remote-tracking branch 'origin/main' into fix-b2-issue-229-copy…
ffumero2003 Oct 29, 2026
cd459b6
docs(b2): state exactly what ReadFrom guarantees after a cancelled copy
ffumero2003 Oct 29, 2026
6212556
Merge remote-tracking branch 'origin/main' into fix-b2-issue-229-copy…
ffumero2003 Oct 29, 2026
8db210f
Merge remote-tracking branch 'origin/main' into fix-b2-issue-229-copy…
ffumero2003 Oct 30, 2026
a37b5fa
test(b2): pin ReadFrom cancellation during blocked error cleanup
ffumero2003 Oct 30, 2026
42b69e2
fix(b2): release the copy guard before upload error cleanup
ffumero2003 Oct 30, 2026
ed73f24
test(b2): pin error mutex release and Close cleanup waiting
ffumero2003 Oct 30, 2026
af786d6
docs(b2): document Writer.Close callback wait
ffumero2003 Oct 30, 2026
6803b3d
test(b2): make Writer.Close callback proof deterministic
ffumero2003 Oct 30, 2026
3f4e6b5
Merge remote-tracking branch 'origin/main' into fix-b2-issue-229-copy…
ffumero2003 Oct 30, 2026
dee1563
test(b2): bound copy cancellation and Close cleanup waits
ffumero2003 Oct 30, 2026
84b17e2
docs(b2): clarify cancellation and breaking Close wait contract
ffumero2003 Oct 30, 2026
5f1c876
test(b2): acknowledge cancellation stub body close results
ffumero2003 Oct 30, 2026
8ac320e
Merge remote-tracking branch 'origin/main' into fix-b2-issue-229-copy…
ffumero2003 Oct 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .changes/unreleased/Changed-20261030-113335.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
kind: Changed
body: >-
**Breaking:** Writer.Close now waits for in-flight part uploads and, with
WithCancelOnError, for b2_cancel_large_file and errf to finish. An errf that calls
Close or waits on the goroutine calling Close deadlocks. Bound the cancellation
RPC's wait with a deadline on the context returned by ctxf; errf must return
promptly, as that deadline does not bound the callback.
time: 2026-10-30T11:33:35.000000-06:00
6 changes: 6 additions & 0 deletions .changes/unreleased/Fixed-20261029-145247.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
kind: Fixed
body: >-
With a non-seekable reader, Writer.ReadFrom now returns the context error on
cancellation without waiting for a Read in progress, and nothing more from the
reader is written after ReadFrom returns (#229).
time: 2026-10-29T14:52:47.457984-06:00
Loading
Loading