Some files named NMC are parameterised with LCO

[ElektrikAkar]

Hi authors,

I am opening this issue for JOSS review openjournals/joss-reviews#11114.

When I look at "lithium_ion_battery_nmc_*.json" files, I see some LCO parameters for positive active material. Or computeOCP_LCO

Could authors clarify whether this is a mislabelling or a deliberate placeholder (where you are only importing some common parameters)?

[augustjohansson]

Yes, this was a serious mislabel. Thank you. The files and documentation is now updated.

[ElektrikAkar]

Thank you for the authors' effort, my questions were answered by PR #103 (commit 90f0d51). The five cell files are now named lithium_ion_battery_lco_*.json, the dependent files are updated, and the documentation now says "LCO-Graphite".

One residual you may want to pick up: twelve exported notebooks still reference the old file name lithium_ion_battery_nmc_graphite.json, and ten of them are rendered on the documentation site (for example https://battmo.org/BattMo/nblinks/runThermalExample.html), so a reader copying the cell may get a file-not-found error.

Examples/Advanced/Plating/notebooks/runCellPlating.ipynb
Examples/Advanced/Plating/notebooks/runSPMplating.ipynb
Examples/Advanced/SEI/notebooks/runBolaySEI.ipynb
Examples/Advanced/notebooks/runGenericStepControlCycle.ipynb
Examples/Advanced/notebooks/runGenericStepControlSimple.ipynb
Examples/Advanced/notebooks/runJellyRoll.ipynb
Examples/Advanced/notebooks/runOnlyThermal.ipynb
Examples/Advanced/notebooks/runThermalExample.ipynb
Examples/Basic/notebooks/battMoTutorial.ipynb
Examples/Basic/notebooks/runBatteryP2D.ipynb
Examples/Basic/notebooks/runControlExamples.ipynb
Examples/Composite/notebooks/runSiliconGraphiteBattery.ipynb