Skip to content

Add Node.js version 26.5.0 with configuration and launch scripts - #42

Merged
jwaisner merged 2 commits into
mainfrom
26.5.0
Jul 18, 2026
Merged

Add Node.js version 26.5.0 with configuration and launch scripts#42
jwaisner merged 2 commits into
mainfrom
26.5.0

Conversation

@N6REJ

@N6REJ N6REJ commented Jul 11, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@N6REJ N6REJ added the enhancement ✨ Improve program label Jul 11, 2026
@qodo-code-review

qodo-code-review Bot commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

PR Summary by Qodo

Add Node.js 26.5.0 bundle with BEARSAMPP config and launch script

✨ Enhancement ⚙️ Configuration changes 🕐 10-20 Minutes

Grey Divider

AI Description

• Add a new Node.js 26.5.0 bundle with versioned BEARSAMPP configuration
• Provide npm/npmrc defaults and Windows launch script to set npm globalconfig/prefix
• Bump bundle release metadata to publish the updated Node.js package
Diagram

graph TD
  A["build.properties"] --> B["Node.js 26.5.0 bundle"] --> C["bearsampp.conf"] --> D["launch.bat"] --> E["npmrc (etc)"] --> F["npmrc (node_modules)"]
Loading
High-Level Assessment

The following are alternative approaches to this PR:

1. Template versioned bundle files at build time
  • ➕ Avoids duplicating npmrc/launcher/conf content across versions
  • ➕ Reduces risk of path/version mismatches when adding future Node.js versions
  • ➖ Requires adding templating logic to the build/release pipeline
  • ➖ Harder to hotfix a single version’s scripts without adjusting templates
2. Shared launcher + per-version environment file
  • ➕ Single launch.bat maintained, per-version file only sets VERSION/PATH
  • ➕ Keeps behavior consistent across all Node.js versions
  • ➖ Introduces an additional indirection layer for debugging/support
  • ➖ Requires careful path resolution to remain portable in Windows batch

Recommendation: The PR’s approach (fully version-scoped folder with explicit config/scripts) is appropriate for packaging/distribution and minimizes runtime coupling between versions. If many Node.js versions are expected to be added frequently, consider templating or a shared launcher to reduce duplication and prevent future version/path drift.

Files changed (7) +31 / -1

Enhancement (1) +12 / -0
launch.batAdd launcher to set npm prefix/globalconfig for 26.5.0 +12/-0

Add launcher to set npm prefix/globalconfig for 26.5.0

• Creates a Windows batch script that derives the Node.js bundle path, writes npmrc prefix into embedded npm config, then runs nodevars and sets npm globalconfig to that npmrc.

bin/nodejs26.5.0/launch.bat

Other (6) +19 / -1
bearsampp.confAdd BEARSAMPP Node.js 26.5.0 bundle configuration +8/-0

Add BEARSAMPP Node.js 26.5.0 bundle configuration

• Introduces per-version configuration fields for Node.js executable, npm entrypoints, launcher, and npmrc location. Includes bundleRelease placeholder for packaging metadata substitution.

bin/nodejs26.5.0/bearsampp.conf

npmrcAdd npm defaults for Node.js 26.5.0 (etc/npmrc) +4/-0

Add npm defaults for Node.js 26.5.0 (etc/npmrc)

• Defines npm cache location and points global/user config and init-module to the versioned etc directory using ~BEARSAMPP_WIN_PATH~.

bin/nodejs26.5.0/etc/npmrc

npmrc.berAdd packaged npm defaults template (etc/npmrc.ber) +4/-0

Add packaged npm defaults template (etc/npmrc.ber)

• Adds the .ber variant mirroring npmrc so the packaged bundle has consistent default paths for cache/config/init.

bin/nodejs26.5.0/etc/npmrc.ber

npmrcAdd embedded npm prefix configuration for 26.5.0 +1/-0

Add embedded npm prefix configuration for 26.5.0

• Adds an npmrc under node_modules/npm to set the prefix to the versioned Node.js directory using ~BEARSAMPP_WIN_PATH~.

bin/nodejs26.5.0/node_modules/npm/npmrc

npmrc.berAdd packaged embedded npm prefix template (npmrc.ber) +1/-0

Add packaged embedded npm prefix template (npmrc.ber)

• Adds the .ber variant of the embedded npmrc so packaging can preserve the intended prefix configuration.

bin/nodejs26.5.0/node_modules/npm/npmrc.ber

build.propertiesBump bundle release to 2026.7.11 +1/-1

Bump bundle release to 2026.7.11

• Updates bundle.release value to reflect the new published bundle contents for the Node.js package.

build.properties

@qodo-code-review

qodo-code-review Bot commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📜 Skill insights (0)

Grey Divider


Remediation recommended

1. npmrc prefix version mismatch ✓ Resolved 🐞 Bug ≡ Correctness
Description
The 26.5.0 bundle ships node_modules/npm/npmrc (and npmrc.ber) with a prefix pointing at
nodejs26.3.0, making the packaged default config inconsistent with the 26.5.0 folder/version.
Although launch.bat rewrites npmrc at runtime, the on-disk default remains wrong until that script
runs and can misconfigure any workflow that reads the file directly beforehand.
Code

bin/nodejs26.5.0/node_modules/npm/npmrc[1]

+prefix = ~BEARSAMPP_WIN_PATH~\bin\nodejs\nodejs26.3.0\
Evidence
In the new 26.5.0 bundle, both npmrc files still hardcode the 26.3.0 directory, while the previous
26.3.0 bundle correctly points to itself; additionally, the bundle’s launch script shows npmrc is
intended to carry the active-version prefix.

bin/nodejs26.5.0/node_modules/npm/npmrc[1-1]
bin/nodejs26.5.0/node_modules/npm/npmrc.ber[1-1]
bin/nodejs26.3.0/node_modules/npm/npmrc[1-1]
bin/nodejs26.5.0/launch.bat[4-10]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

### Issue description
The newly added Node.js 26.5.0 bundle contains `node_modules/npm/npmrc` (and `npmrc.ber`) with a `prefix` path that still references `nodejs26.3.0`.

### Issue Context
Other bundles set `prefix` to their own version directory. `launch.bat` rewrites `npmrc` at runtime, but the packaged default config should still be correct and consistent.

### Fix Focus Areas
- bin/nodejs26.5.0/node_modules/npm/npmrc[1-1]
- bin/nodejs26.5.0/node_modules/npm/npmrc.ber[1-1]

### Expected change
Set both files to:
```
prefix = ~BEARSAMPP_WIN_PATH~\bin\nodejs\nodejs26.5.0\
```

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

Previous review results

Review updated until commit 01925a7

Results up to commit 9e2631d


🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0) 🎨 UX issues (0) 🔗 Cross-repo conflicts (0) 📜 Skill insights (0)


Remediation recommended
1. npmrc prefix version mismatch ✓ Resolved 🐞 Bug ≡ Correctness
Description
The 26.5.0 bundle ships node_modules/npm/npmrc (and npmrc.ber) with a prefix pointing at
nodejs26.3.0, making the packaged default config inconsistent with the 26.5.0 folder/version.
Although launch.bat rewrites npmrc at runtime, the on-disk default remains wrong until that script
runs and can misconfigure any workflow that reads the file directly beforehand.
Code

bin/nodejs26.5.0/node_modules/npm/npmrc[1]

+prefix = ~BEARSAMPP_WIN_PATH~\bin\nodejs\nodejs26.3.0\
Evidence
In the new 26.5.0 bundle, both npmrc files still hardcode the 26.3.0 directory, while the previous
26.3.0 bundle correctly points to itself; additionally, the bundle’s launch script shows npmrc is
intended to carry the active-version prefix.

bin/nodejs26.5.0/node_modules/npm/npmrc[1-1]
bin/nodejs26.5.0/node_modules/npm/npmrc.ber[1-1]
bin/nodejs26.3.0/node_modules/npm/npmrc[1-1]
bin/nodejs26.5.0/launch.bat[4-10]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

### Issue description
The newly added Node.js 26.5.0 bundle contains `node_modules/npm/npmrc` (and `npmrc.ber`) with a `prefix` path that still references `nodejs26.3.0`.

### Issue Context
Other bundles set `prefix` to their own version directory. `launch.bat` rewrites `npmrc` at runtime, but the packaged default config should still be correct and consistent.

### Fix Focus Areas
- bin/nodejs26.5.0/node_modules/npm/npmrc[1-1]
- bin/nodejs26.5.0/node_modules/npm/npmrc.ber[1-1]

### Expected change
Set both files to:
```
prefix = ~BEARSAMPP_WIN_PATH~\bin\nodejs\nodejs26.5.0\
```

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Qodo Logo

Comment thread bin/nodejs26.5.0/node_modules/npm/npmrc Outdated
@jwaisner
jwaisner merged commit 8aa9a9e into main Jul 18, 2026
3 checks passed
@jwaisner
jwaisner deleted the 26.5.0 branch July 18, 2026 14:56
@qodo-code-review

Copy link
Copy Markdown
Contributor

Code review by qodo was updated up to the latest commit 01925a7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement ✨ Improve program

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants