You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
• Add a new Node.js 26.5.0 bundle with versioned BEARSAMPP configuration
• Provide npm/npmrc defaults and Windows launch script to set npm globalconfig/prefix
• Bump bundle release metadata to publish the updated Node.js package
The following are alternative approaches to this PR:
1. Template versioned bundle files at build time
➕ Avoids duplicating npmrc/launcher/conf content across versions
➕ Reduces risk of path/version mismatches when adding future Node.js versions
➖ Requires adding templating logic to the build/release pipeline
➖ Harder to hotfix a single version’s scripts without adjusting templates
2. Shared launcher + per-version environment file
➕ Single launch.bat maintained, per-version file only sets VERSION/PATH
➕ Keeps behavior consistent across all Node.js versions
➖ Introduces an additional indirection layer for debugging/support
➖ Requires careful path resolution to remain portable in Windows batch
Recommendation: The PR’s approach (fully version-scoped folder with explicit config/scripts) is appropriate for packaging/distribution and minimizes runtime coupling between versions. If many Node.js versions are expected to be added frequently, consider templating or a shared launcher to reduce duplication and prevent future version/path drift.
Files changed (7) +31 / -1
Enhancement (1) +12 / -0
launch.batAdd launcher to set npm prefix/globalconfig for 26.5.0+12/-0
Add launcher to set npm prefix/globalconfig for 26.5.0
• Creates a Windows batch script that derives the Node.js bundle path, writes npmrc prefix into embedded npm config, then runs nodevars and sets npm globalconfig to that npmrc.
1. npmrc prefix version mismatch✓ Resolved🐞 Bug≡ Correctness
Description
The 26.5.0 bundle ships node_modules/npm/npmrc (and npmrc.ber) with a prefix pointing at
nodejs26.3.0, making the packaged default config inconsistent with the 26.5.0 folder/version.
Although launch.bat rewrites npmrc at runtime, the on-disk default remains wrong until that script
runs and can misconfigure any workflow that reads the file directly beforehand.
In the new 26.5.0 bundle, both npmrc files still hardcode the 26.3.0 directory, while the previous
26.3.0 bundle correctly points to itself; additionally, the bundle’s launch script shows npmrc is
intended to carry the active-version prefix.
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution
### Issue description
The newly added Node.js 26.5.0 bundle contains `node_modules/npm/npmrc` (and `npmrc.ber`) with a `prefix` path that still references `nodejs26.3.0`.
### Issue Context
Other bundles set `prefix` to their own version directory. `launch.bat` rewrites `npmrc` at runtime, but the packaged default config should still be correct and consistent.
### Fix Focus Areas
- bin/nodejs26.5.0/node_modules/npm/npmrc[1-1]
- bin/nodejs26.5.0/node_modules/npm/npmrc.ber[1-1]
### Expected change
Set both files to:
```
prefix = ~BEARSAMPP_WIN_PATH~\bin\nodejs\nodejs26.5.0\
```
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
1. npmrc prefix version mismatch✓ Resolved🐞 Bug≡ Correctness
Description
The 26.5.0 bundle ships node_modules/npm/npmrc (and npmrc.ber) with a prefix pointing at
nodejs26.3.0, making the packaged default config inconsistent with the 26.5.0 folder/version.
Although launch.bat rewrites npmrc at runtime, the on-disk default remains wrong until that script
runs and can misconfigure any workflow that reads the file directly beforehand.
In the new 26.5.0 bundle, both npmrc files still hardcode the 26.3.0 directory, while the previous
26.3.0 bundle correctly points to itself; additionally, the bundle’s launch script shows npmrc is
intended to carry the active-version prefix.
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution
### Issue description
The newly added Node.js 26.5.0 bundle contains `node_modules/npm/npmrc` (and `npmrc.ber`) with a `prefix` path that still references `nodejs26.3.0`.
### Issue Context
Other bundles set `prefix` to their own version directory. `launch.bat` rewrites `npmrc` at runtime, but the packaged default config should still be correct and consistent.
### Fix Focus Areas
- bin/nodejs26.5.0/node_modules/npm/npmrc[1-1]
- bin/nodejs26.5.0/node_modules/npm/npmrc.ber[1-1]
### Expected change
Set both files to:
```
prefix = ~BEARSAMPP_WIN_PATH~\bin\nodejs\nodejs26.5.0\
```
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.