Apply copied RPC credentials and timeouts - #236
Open
tolgahanbozkurt wants to merge 1 commit into
Open
tolgahanbozkurt wants to merge 1 commit into
tolgahanbozkurt wants to merge 1 commit into
Conversation
|
Warning Review limit reachedNext included review available in 59 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wallet long polling copies the daemon connection settings into a second HTTP client. The copy updates the stored credentials and timeout but never applies them to the HTTP session. This causes 401 responses from authenticated daemons and lets an existing session retain old credentials or timeouts.
Apply the copied settings before the next request, and return immediately on self-copy to avoid locking the same mutex twice.
Validated with the real HTTP client and a local HTTP server: copied, replaced and cleared credentials, timeout changes, and self-copy all pass. The original code fails the five request cases and hangs on self-copy.