Skip to content

Fix peer selection bounds #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tolgahanbozkurt wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Fix peer selection bounds #237

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/p2p/net_node.inl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1035,7 +1035,7 @@ namespace nodetool
static_cast<size_t>(-1.0 / rate * std::log(1.0 - u * (1.0 - std::exp(-rate * size))));

MDEBUG("Random connection index= "<<res<<" ,(size="<< size<<")");
return res;
return std::min(res, size - 1);
}
//-----------------------------------------------------------------------------------
template<class t_payload_net_handler>
Expand Down Expand Up @@ -1367,10 +1367,11 @@ namespace nodetool
MDEBUG("No available peer in " << (use_white_list ? "white" : "gray") << " list filtered by " << next_needed_pruning_stripe);
return false;
}
max_random_index = std::min<size_t>(filtered.size() - 1, 20);
if (use_white_list)
{
// if using the white list, we first pick in the set of peers we've already been using earlier
random_index = get_random_exp_index(std::min<uint64_t>(filtered.size() - 1, 20));
random_index = get_random_exp_index(filtered.size());
std::lock_guard lock{m_used_stripe_peers_mutex};
if (next_needed_pruning_stripe > 0 && next_needed_pruning_stripe <= (1ul << cryptonote::PRUNING_LOG_STRIPES) && !m_used_stripe_peers[next_needed_pruning_stripe-1].empty())
{
Expand Down
Loading