Prevent disabled vote sites from being auto-created - #1553
Merged
Conversation
BenCodez
marked this pull request as ready for review
August 18, 2026 00:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Disabled vote sites are intentionally excluded from the in-memory list of loaded sites. That made a configured-but-disabled site look missing during vote ingestion, allowing
AutoCreateVoteSitesto generate the same site again withEnabled: true.Implementation
ConfigVoteSites#getRawVoteSiteNames()to return actualVoteSitesconfiguration sections without filtering onEnabledor validating site settings.VoteSiteManagerfor:site.example→site_example;ServiceSitevalues;hasConfiguredVoteSite(String...)while preservinghasVoteSite(...)as a loaded-site check.VoteSiteManager#getVoteSite(...);VotiferEvent.Regression coverage
Added 14 focused tests covering:
VoteSitesroots;ServiceSite, and display name;VoteSiteManagerand Votifier ingestion paths.Verification
AI disclosure
This pull request was created with assistance from OpenAI and reviewed by BenCodez.