Skip to content

Feature: search new build-system field - #14

Open
rouson wants to merge 8 commits into
BerkeleyLab:mainfrom
rouson:read-build-system-info
Open

rouson wants to merge 8 commits into
BerkeleyLab:mainfrom
rouson:read-build-system-info

Conversation

@rouson

@rouson rouson commented Sep 21, 2026

Copy link
Copy Markdown
Collaborator

This PR

  1. Adds a build_systems_ component in indexed_pacakge_t and
  2. Adds a check for --build-systems or -b command-line arguments
  3. Adds a search of the new component when
    a. either of the new command-line arguments is present or
    b. when searching all componenents, which remains the default.
  4. Fixes an issue in which failed package-index downloads led to effectively erasing the contents of the package index.
  5. Fixes a typo in a comment.

Comment thread .github/workflows/build.yml Outdated
Comment thread .github/workflows/build.yml
@rouson

rouson commented Sep 24, 2026

Copy link
Copy Markdown
Collaborator Author

@bonachea feel free to push any changes you like to this PR. The changes to build.yml were suggested by Copilot to fix two CI failures, but with these edits, there are now at least three failures. Arrrgghh... If you'd like you can start by reverting the two most recent commits. Once everything pass, please approve and then either one of us can merge.

@rouson

rouson commented Sep 27, 2026

Copy link
Copy Markdown
Collaborator Author

@bonachea after reverting the two AI-suggested commits, 41 of 42 checks pass. One check has been running for nearly an hour and appears to be stalled on installing flang, a step which took 22 sec in another macOS CI check. I see a "Cancel workflow" button, but I fear that will restart all 42 checks so I'll wait for this one to finish and then restart it if it fails. What's also weird I that I see checks that passed after ~30 sec and checks that passed after running over 100 minutes. Strange.

@bonachea

Copy link
Copy Markdown
Member

@bonachea after reverting the two AI-suggested commits, 41 of 42 checks pass. One check has been running for nearly an hour and appears to be stalled on installing flang, a step which took 22 sec in another macOS CI check. I see a "Cancel workflow" button, but I fear that will restart all 42 checks so I'll wait for this one to finish and then restart it if it fails. What's also weird I that I see checks that passed after ~30 sec and checks that passed after running over 100 minutes. Strange.

This is because Homebrew retired the flang bottle for macos-14 so it's building flang from source (and will probably time out after 6 hours).

I'll make a separate CI PR to remove it

@bonachea

Copy link
Copy Markdown
Member

I'll make a separate CI PR to remove it

Now in #15

This commit supports extracting build-system information for
packages in the package_index.yml file.

1. Add a build_system_ string_t component array in the
   indexed_package_t type.
2. Define the build_system_ component by extracting the array
   elements from a space-separated list in a key/array-value
   pair of the following form:

   build_system: fpm cmake

   where "build_system" is the key and "fpm" and "cmake" are
   resulting array elements.
This commit changes the download location for the package index
to a temporary file.  When the download succeeds, as determined
by a non-empty downloaded file, fpm-find moves the file to its
permanent location.
This commit
1. Adds a build-systems component in indexed_pacakge_t and
2. Adds a check for --build-systems or -b command-line arguments
3. Adds a search of the new component when
   a. either of the new command-line arguments is present or
   b. when searching all componenents, which remains the default.
This commit works around a crash that occurs when Julienne's
.separatedBy. or .csv. operators are applied to a zero-sized
string_t array.
@bonachea
bonachea force-pushed the read-build-system-info branch from 99d0028 to 4a9bfd0 Compare September 28, 2026 01:58
@bonachea

Copy link
Copy Markdown
Member

Rebased to pickup CI changes from #15 in main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants