Skip to content

fix: kill discord before writing betterdiscord.asar - #428

Open
Huderon wants to merge 1 commit into
BetterDiscord:developmentfrom
Huderon:fix/InstallBD-action
Open

fix: kill discord before writing betterdiscord.asar#428
Huderon wants to merge 1 commit into
BetterDiscord:developmentfrom
Huderon:fix/InstallBD-action

Conversation

@Huderon

@Huderon Huderon commented Aug 29, 2026

Copy link
Copy Markdown

Summary

fix for #426

Closes Discord before attempting to write betterdiscord.asar. Not sure why this wasn't an issue in the Electron version, but Discord definitely has a handle on the file.

firefox_1787989311_51584

Type of change

  • Bug fix
  • New feature / behavior change
  • UI / component change (frontend)
  • Backend / installer logic (Go)
  • Build / release / CI
  • Refactor (no behavior change)
  • Documentation
  • Other:

Testing

  • bun run check passes (frontend, from frontend/)
  • bun run lint passes (frontend, from frontend/)
  • bun run test passes (frontend, from frontend/)
  • go test ./... passes (backend)

AI disclosure

  • I did not use AI assistance for this PR
  • I used AI assistance and personally reviewed all generated output before submitting
  • An AI agent generated part or all of this PR with minimal personal review. Details:

@zerebos

zerebos commented Aug 29, 2026

Copy link
Copy Markdown
Member

@doggybootsy told you

@doggybootsy

Copy link
Copy Markdown
Member

We should look into how electron writes asars, as this will have issues if the user selects stable but has ptb/canary open

@Huderon

Huderon commented Aug 29, 2026

Copy link
Copy Markdown
Author

Looks like it has R/W share perms, so we should be able to write to it despite the handle

firefox_1788016391_83239

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants