Skip to content

feat!: make encrypt/decrypt async#9150

Draft
bdesoky wants to merge 1 commit into
masterfrom
WCN-174-breaking
Draft

feat!: make encrypt/decrypt async#9150
bdesoky wants to merge 1 commit into
masterfrom
WCN-174-breaking

Conversation

@bdesoky

@bdesoky bdesoky commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

BREAKING CHANGE: synchronous encrypt/decrypt callsites removed

TICKET: WCN-174

This pull request focuses on removing deprecated asynchronous encryption and decryption methods in favor of their synchronous (but promise-returning) replacements across multiple modules. It also simplifies and modernizes key verification logic, updates related tests, and cleans up unused imports. The changes ensure consistency and future-proof the codebase by using only the preferred encryption/decryption interfaces.

Encryption/Decryption Method Updates

  • Replaced all usage of decryptAsync and encryptAsync with decrypt and encrypt throughout the codebase, including in abstract-eth, abstract-lightning, abstract-substrate, and abstract-utxo modules. This affects key decryption for wallets, tokens, and recovery flows. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18]

Key Verification Logic Refactor

  • Removed the deprecated verifyUserPublicKeyAsync function and its usages, updating all references to use the now-async verifyUserPublicKey function instead. Updated the AbstractUtxoCoin class and related files to reflect this change. [1] [2] [3] [4] [5] [6]

Test Suite Modernization

  • Updated test files to use the new encryption interface, including making key preparation asynchronous and ensuring all encrypted keys are generated before tests run. [1] [2] [3] [4]

Code Cleanup

  • Removed unused imports and deprecated code associated with the old async methods, making the codebase cleaner and easier to maintain. [1] [2] [3]

These changes collectively improve code consistency, remove deprecated interfaces, and prepare the codebase for future updates.

@linear-code

linear-code Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

WCN-174

@bdesoky bdesoky force-pushed the WCN-174-breaking branch 6 times, most recently from ea1144f to 4992a5e Compare July 1, 2026 03:02
@bdesoky bdesoky force-pushed the WCN-174-breaking branch from 4992a5e to f9fa896 Compare July 1, 2026 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant