feat!: make encrypt/decrypt async#9150
Draft
bdesoky wants to merge 1 commit into
Draft
Conversation
Contributor
ea1144f to
4992a5e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: synchronous encrypt/decrypt callsites removed
TICKET: WCN-174
This pull request focuses on removing deprecated asynchronous encryption and decryption methods in favor of their synchronous (but promise-returning) replacements across multiple modules. It also simplifies and modernizes key verification logic, updates related tests, and cleans up unused imports. The changes ensure consistency and future-proof the codebase by using only the preferred encryption/decryption interfaces.
Encryption/Decryption Method Updates
decryptAsyncandencryptAsyncwithdecryptandencryptthroughout the codebase, including inabstract-eth,abstract-lightning,abstract-substrate, andabstract-utxomodules. This affects key decryption for wallets, tokens, and recovery flows. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18]Key Verification Logic Refactor
verifyUserPublicKeyAsyncfunction and its usages, updating all references to use the now-asyncverifyUserPublicKeyfunction instead. Updated theAbstractUtxoCoinclass and related files to reflect this change. [1] [2] [3] [4] [5] [6]Test Suite Modernization
Code Cleanup
These changes collectively improve code consistency, remove deprecated interfaces, and prepare the codebase for future updates.