Repository navigation
Improve Qwen quality defaults, guidance, and native 2K resolution - #73
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Qwen previously locked guidance to CFG 1, hid negative prompts, and defaulted to 25 steps. Default to Quality (40 steps) and CFG 2.5, expose guidance and negative prompts in the existing advanced controls, and preserve saved sampling choices and gallery reuse.
Add a Qwen-only native 2K resolution button with the official aspect-ratio dimensions. First selection uses 2K on GPUs with at least 32 GB VRAM and M on smaller or unknown GPUs. Preserve independent Krea/Qwen resolution choices, existing custom sizes, and Krea sampling settings. The sampler remains Euler/simple while a controlled comparison is reviewed.
Validation: Node syntax checks, full node:test suite, and focused tests for guidance persistence, negative prompts, native dimensions, and model switching. BMPro is already on current stable ComfyUI v0.37.0. Completed a 19-image fixed-prompt/seed sampler/steps/CFG comparison on BMPro. Verified native 2K dimensions, narrow/desktop layouts, editable CFG persistence after reload, and a real edit request using the new API defaults (40 steps, CFG 2.5). All 1,327 tests also passed on BMPro; GitHub CI passed on Windows, macOS, and Linux. Deployment will follow merge.