Repository navigation
Add blocks-api skill and npx skills install scaffolding - #1
Conversation
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
This pull request was created from a Blocks session. |
…sessions-get-overview.md Drop references/sessions.md, which duplicated the public REST docs. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
@cube /claude /reviewreview |
|
None of the five review comments block the merge. All five came from the review bot at 7/10; my independent scores run 2–6, and both comments I sent for deeper checking dropped to 4. Two comments are valid as written, one is valid but its suggested fix would lose data, one has the right fix on a wrong premise, and one is invalid.
What I found#1, plan step (6 → 4).
#2, tool-call example (5 → 4).
#3, Setup note. An agent hitting 422 does reach the fallback in the playbook. A one-line pointer in Setup is cheap but not required. #4, description grammar. The wording is real, but that description is your verbatim text from the last round. It only affects how the listing reads, not whether the skill triggers correctly. #5, fallback call. The comment contradicts itself mid-sentence ("…actually also matches on role"). I checked on dev: Next stepI haven't changed any code, PR comments, or the PR description. Tell me which numbers to fix (e.g. "1, 2"). Then I'll:
|
…eader (#2) Mirrors the repository scaffolding of blocks-ci-sessions. The CI job names are the required status checks on main. Co-authored-by: Blocks Task Runner <ae@alejandro.ltd> Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
|
User Message:
I replied to all five review comments and resolved each one. Since you didn't pick any, no code changed and nothing was pushed. Replies: each reply says the comment is out of scope and explains why its severity changed:
PR description: I added a "Review comments" section at the bottom, with one line per comment marked not picked and out of scope. |
| https://docs.blocks.team/rest-api/sessions/get | ||
| https://docs.blocks.team/rest-api/sessions/messages | ||
| https://docs.blocks.team/rest-api/sessions/artifacts |
There was a problem hiding this comment.
The third link in this Docs section is dead: https://docs.blocks.team/rest-api/sessions/artifacts returns 404 today, and the docs site's sitemap / quick-start page contain no artifacts page at all — it presumably ships with the client-monorepo #937 docs you reference in the PR body, at a path that's still a guess until that lands. Unlike the API calls, there's no fallback covering the pre-deploy side here: the skill deliberately delegates endpoint/field detail to the public docs, so once this merges, an installed agent that follows this link for artifact detail gets a 404 with nowhere to go. Suggest either dropping the line until the page exists, pointing at the quick-start in the meantime, or re-verifying the final URL against #937 before merge so the path matches what actually ships.
Severity 7/10 · View on dashboard · PR Review Settings
💡 Tip: You can disable PR Review for Draft PRs in
PR Review Settings
What this is
Bootstraps
BlocksOrg/skillsas a repo installable with thenpx skills addparadigm and ships the first skill,blocks-api.mainwas seeded with a singleInitial commit(MITLICENSEand.gitignore) so this PR has a base branch. Everything else lives in this PR.Install
Or the one-liner:
curl -fsSL https://raw.githubusercontent.com/BlocksOrg/skills/main/install.sh | shLayout
SKILL.mdis deliberately an index. Each reference file is one ordered walkthrough for one task; new capabilities get a new row in the table and a new reference file. Endpoint, parameter, and field detail is left to the public docs so the skill does not go stale.What
blocks-apicovers todaysessions-get-overview.md: fetching an existing session by ID, in the order an agent should do it:title,pull_requests,plan_artifact_ids,_links.messages).plan_artifact_ids[-1]and the artifact endpoint (presigned URL, no auth header).?type=message&role=user&role=assistant, with the two-call fallback for deployments whereroleis single-valued.type=tool_call, JSON-encodedmessage), outcomes-only (type=final_message), single-thread reads, andgtspolling.Verified against dev
npx skills add . --listandnpx skills add https://github.com/BlocksOrg/skills --listboth discover exactly one skill,blocks-api.sh -n install.shpasses.One quirk surfaced during verification and is documented in the playbook:
_links.self.hrefand_links.new_messages.hrefdroptypeandthread_id(the latter keeps onlygts), so polling and pagination URLs must be rebuilt with your own filters.Dependency
The one-call overview (
role=user&role=assistant),plan_artifact_ids, andGET /sessions/{id}/artifacts/{artifact_id}ship with orchestration-svc #1486 (docs: client-monorepo #937). Until that is deployed those calls return 422 and 404 respectively on dev. The playbook documents the fallback, so it works on both sides of that deploy.Out of scope
Create session, follow-ups, non-plan
fileartifacts, plugin manifests, CI validation workflow, release tagging.Review comments
None picked; all resolved with re-ranked severity replies.
plan_artifact_ids[-1]yields"null"when empty (7 → 4) — out of scopeBlocks" (7 → 3) — out of scoperole=assistant(7 → 2, invalid) — out of scope🤖 Generated with Claude Code