Repository navigation
Keep favorites and their names in sync across phone and PC - #14
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Favorites previously lived separately in each browser, so saving or renaming a node on a PC did not update the phone. Store favorites on the monitored node and refresh each dashboard from that shared list. Provide an explicit import for existing browser favorites, preserving names already shared. Recent Nodes and Auto-switch remain browser preferences.
Writes use atomic persistence and revision checks to reject stale edits. Read/write access follows Remote Admin policy; writes require same-origin JSON and CSRF when authenticated. Storage/configuration failures preserve the saved data and show an unavailable state. Favorite edits never issue radio commands.
Validation: 268 Python tests passed (six Windows skips); all 14 JavaScript suites passed. Two independent desktop/mobile Chromium contexts used the real HTTP/favorites service to verify import, save, rename, removal, automatic refresh, reload and persistence. Five-width rendering and public-tree/whitespace checks passed. See docs/SHARED_FAVORITES_VALIDATION.md.
Deploy backend and dashboard together. Existing 0.1.5-alpha.1 release installers and the customized operating node are unchanged; actual phone/gateway acceptance follows a reviewed deployment.